Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore dropping large buffers #364

Closed
pohly opened this issue Jan 31, 2023 · 2 comments · Fixed by #366
Closed

restore dropping large buffers #364

pohly opened this issue Jan 31, 2023 · 2 comments · Fixed by #366
Assignees
@pohly
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@pohly
Copy link

pohly commented Jan 31, 2023

/kind bug

What steps did you take and what happened:

buffers.PutBuffer used to discard buffers larger than 256 bytes. That got dropped as an unnecessary safeguard, but was called out again as something that might be useful in kubernetes/kubernetes#115277 (review)

What did you expect to happen:

PutBuffer should simply ignore buffers larger than 256 bytes and let the garbage collector free them.

/assign
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 31, 2023
@k8s-ci-robot
Copy link

This issue is currently awaiting triage.

If klog contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pohly pohly mentioned this issue Jan 31, 2023
Merged
@pohly
Copy link
Author

pohly commented Feb 1, 2023

See also golang/go#23199

@pohly pohly mentioned this issue Feb 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pohly pohly

Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

buffer: restore dropping of too large buffers pohly/klog
2 participants
@pohly @k8s-ci-robot