Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textlogger: don't leak internal VState in the Config API #367

Closed
pohly opened this issue Feb 8, 2023 · 2 comments · Fixed by #368
Closed

textlogger: don't leak internal VState in the Config API #367

pohly opened this issue Feb 8, 2023 · 2 comments · Fixed by #368
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pohly
Copy link

pohly commented Feb 8, 2023

/kind bug

What steps did you take and what happened:

Config embeds VState, which makes VState methods V and VModule accessible. This was intentional because it enables verbosity level changes at runtime. However, it's not a good solution because the internal packages should be completely hidden.

What did you expect to happen:

Config should define its own API for v and vmodule changes. This might even be the same as in VState.

Advantages:

  • more discoverable
  • proper layering
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 8, 2023
@pohly
Copy link
Author

pohly commented Feb 8, 2023

/assign

@logicalhan
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants