Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compose constructs we support are still there in unsupportedKey #207

Closed
surajssd opened this issue Oct 13, 2016 · 1 comment · Fixed by #230
Closed

compose constructs we support are still there in unsupportedKey #207

surajssd opened this issue Oct 13, 2016 · 1 comment · Fixed by #230
Assignees
@ngtuna

Comments

@surajssd
Copy link
Member

We do support things like CPUSet, CPUShares, etc. as seen in code here but we still have them in unsupportedKey map. So this is inconsistency, which should be fixed.
@ngtuna
Copy link
Contributor

ngtuna commented Oct 13, 2016

Right. Unsupported keys hasn't been tracked for a while.

@ngtuna ngtuna self-assigned this Oct 13, 2016
@ngtuna ngtuna mentioned this issue Oct 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngtuna ngtuna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update unsupported key list ngtuna/kompose
2 participants
@ngtuna @surajssd