Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: kompose up, ps, delete, scale redirect to kubectl #27

Closed
janetkuo opened this issue Jul 7, 2016 · 10 comments
Closed

Idea: kompose up, ps, delete, scale redirect to kubectl #27

janetkuo opened this issue Jul 7, 2016 · 10 comments

Comments

@janetkuo
Copy link
Member

janetkuo commented Jul 7, 2016

kompose up, ps, delete, scale are duplicate of kubectl, but are easier to learn from compose users perspective.

How about we suggest users the right kubectl command for each kompose command so that we don't need to reinvent the wheel? Something like:

$ kompose up
To initiate your compose services, run "kubectl create -f web-rc.json -f web-svc.json".

Thoughts?

@dustymabe
Copy link
Contributor

I like it but maybe we shouldn't make it so manual by making them copy/paste. Maybe something like:

$ kompose up
To initiate your compose services, run "kubectl create -f web-rc.json -f web-svc.json".
Would you like us to run that command for you now? (y/n) 

@ngtuna
Copy link
Contributor

ngtuna commented Jul 11, 2016

Ah ha, that makes more sense to me @dustymabe

@janetkuo
Copy link
Member Author

@dustymabe Thanks that sounds good!

@sebgoa
Copy link
Contributor

sebgoa commented Jul 12, 2016

yes +1
we can support up, ps and delete via a simple wrapper to kubectl
and focus on the conversion for now.

@janetkuo
Copy link
Member Author

Open question: what's the right behavior of kompose up?

  1. If there's no existing converted k8s files: it should tell the users to run kompose convert
  2. If there's multiple existing k8s files: should it just create whatever config files we have? What if those files are stale (docker-compose.yaml updated since last conversion)? What if we have more than one k8s files (.yaml, .json, different controllers...)? We can just convert again and then create those k8s primitives, but we don't have the options in kompose up like we do in kompose convert.

@janetkuo
Copy link
Member Author

janetkuo commented Jul 26, 2016

Open question: what's the right behavior of kompose up?

Update per earlier discussion with @Runseb and @ngtuna: kompose up will do the equivalent of kompose convert && kubectl create -f <svc_files> -f <deployment_files> ... (note that we only support default convert behavior, i.e. converting to deployments)

@ngtuna
Copy link
Contributor

ngtuna commented Jul 26, 2016

link to #40

@ngtuna
Copy link
Contributor

ngtuna commented Aug 2, 2016

Close as dup #40 #41

@ngtuna ngtuna closed this as completed Aug 2, 2016
@janetkuo
Copy link
Member Author

janetkuo commented Aug 2, 2016

@ngtuna what about kompose ps and kompose scale?

@ngtuna
Copy link
Contributor

ngtuna commented Aug 2, 2016

@janetkuo By closing this issue, I just wanna make some clean up on issues. We can have another discussion on kompose ps and kompose scale, then we open the corresponding issues for them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants