Generating both ReplicationControllers and Deployments

[kadel]

Running kompose convert --deployment generates files with Services, Deployments and also Replication Controllers.

Shouldn't this generate just Deployments and Services?

Some for Daemon Sets and Replica Sets.

[janetkuo]

+1

[janetkuo]

A fix for this is easy. Here are some more things to think about:

1. This breaks backward compatibility.
2. How'd a user create an RC and other controllers at the same time? One can do kompose convert --d --ds, but there's no flag for RC (since it's the default controller).
3. Should we change Deployment to be default controller being created instead?

[ngtuna]

+1

@kadel Originally kompose generates rc, svc by default but yes we should do that. I will work on that or you can also freely go ahead to send us PR

[ngtuna]

@janetkuo @kadel the tricky point here is just for --stdout option where user would like to pipe with kubectl. Otherwise, generating RC by default does not harm anymore as user has option to pick up files he want for further operation.

[janetkuo]

@ngtuna --stdout and --out stop multiple controllers from being created already.

[ngtuna]

@janetkuo Ah... yes you're right. I totally agree to change DeploymentSet to be default controller being created. Then we can keep RC as optional --rc 😺