Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional tests for OpenShift down #323

Closed
procrypt opened this issue Dec 5, 2016 · 3 comments
Closed

Functional tests for OpenShift down #323

procrypt opened this issue Dec 5, 2016 · 3 comments
Labels
kind/testing

Comments

@procrypt
Copy link

procrypt commented Dec 5, 2016 •
edited
Loading

Need functional tests for #280
@ericchiang
Copy link

Shouldn't this be addressed in the PR? Why the extra issue?

@kadel
Copy link
Member

kadel commented Dec 5, 2016 •
edited
Loading

Almost all code in this touches OpenShift cluster.
To test this, it will require setting up OpenShift cluster or mocking its api.

The same situation is with up/down for k8s. We will have to figure out how we will test all this.

We don't want to block PR on that. So @procrypt created this separate issue.

@procrypt procrypt changed the title Unit test for OpenShift down Functional tests for OpenShift down Dec 5, 2016
@ashetty1 ashetty1 mentioned this issue Mar 1, 2017
Merged
@surajnarwade
Copy link
Contributor

@cdrage @kadel, we can close this issue as functional tests are being added for kompose down by @ashetty1

@cdrage cdrage closed this as completed Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kadel @ericchiang @surajssd @cdrage @procrypt @surajnarwade