Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating v1 and only supporting v2 and v3 #430

Closed
cdrage opened this issue Feb 16, 2017 · 4 comments
Closed

Deprecating v1 and only supporting v2 and v3 #430

cdrage opened this issue Feb 16, 2017 · 4 comments

Comments

@cdrage
Copy link
Member

cdrage commented Feb 16, 2017

v1 will eventually be deprecated by docker-compose. As well as the fact that v1 honestly doesn't convert that well when going from Docker to Kubernetes (especially with the networking + volumes section of v2 providing a lot of ease for it).

Should we deprecate v1 and focus our efforts on only v2 and v3?

@kadel
Copy link
Member

kadel commented Feb 17, 2017

This made me thinking, so I tried to get some statistics how are different versions used.

docker-compose.yml files in github, only ~29% v2 files and rest v1

How I got there:
I've used Google BigQuery with github public data set: https://cloud.google.com/bigquery/public-data/github

To make it easy I assume that there is no v3 (or at least right now it is so small number that it doesn't matter).
Another assumption is that v2 files are all the docker-compose.yml files that contains "version:" string. This gets a few false positives but I shouldn't be statistically significant.

I've used sample tables, they are smaller, but statistically it shouldn't matter.

all docker-compose.yml files: 197
files with "version:": 57 ~= 29%

queries I've used:

SELECT
  COUNT(*)
FROM
  [bigquery-public-data:github_repos.sample_contents]
WHERE
  sample_path LIKE "%docker-compose.y%"
SELECT
  COUNT(*)
FROM
  [bigquery-public-data:github_repos.sample_contents]
WHERE
  sample_path LIKE "%docker-compose.y%"
  AND content CONTAINS "version:"

And now when I've done all this I'm not sure if it says anything 🤣
Reason behind big number of old v1 files might be that they are just old and nobody is using them :-D
It might be better to get only files that were modified in last year or so, but that will be tricky to do :-(

I'll keep it here, because someone might find it interesting.

+1 for deprecating v1 in kompose.

@sebgoa
Copy link
Contributor

sebgoa commented Feb 17, 2017

nice data query. I think it is very informative.
we could try to run a poll on Twitter (not that it would be super viable but it would give some data points).

I think we need to have v3 supported (in a branch), before removing v1.

We can have a policy to support the current version of compose and the one before.

@kadel
Copy link
Member

kadel commented Feb 17, 2017

Agreed we shouldn't drop v1 before supporting v3

@cdrage
Copy link
Member Author

cdrage commented Jun 20, 2017

I agree with @kadel

Let's stick with v2 / v3 for now and still support v1 (it's not that hard to maintain)

@cdrage cdrage closed this as completed Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants