-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating v1 and only supporting v2 and v3 #430
Comments
This made me thinking, so I tried to get some statistics how are different versions used. docker-compose.yml files in github, only ~29% v2 files and rest v1 How I got there: To make it easy I assume that there is no v3 (or at least right now it is so small number that it doesn't matter). I've used sample tables, they are smaller, but statistically it shouldn't matter. all docker-compose.yml files: 197 queries I've used: SELECT
COUNT(*)
FROM
[bigquery-public-data:github_repos.sample_contents]
WHERE
sample_path LIKE "%docker-compose.y%" SELECT
COUNT(*)
FROM
[bigquery-public-data:github_repos.sample_contents]
WHERE
sample_path LIKE "%docker-compose.y%"
AND content CONTAINS "version:" And now when I've done all this I'm not sure if it says anything 🤣 I'll keep it here, because someone might find it interesting. +1 for deprecating v1 in kompose. |
nice data query. I think it is very informative. I think we need to have v3 supported (in a branch), before removing v1. We can have a policy to support the current version of compose and the one before. |
Agreed we shouldn't drop v1 before supporting v3 |
I agree with @kadel Let's stick with v2 / v3 for now and still support v1 (it's not that hard to maintain) |
v1 will eventually be deprecated by docker-compose. As well as the fact that v1 honestly doesn't convert that well when going from Docker to Kubernetes (especially with the networking + volumes section of v2 providing a lot of ease for it).
Should we deprecate v1 and focus our efforts on only v2 and v3?
The text was updated successfully, but these errors were encountered: