Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for disable-attach-detach-reconcile-sync flag in kube-controller-manager #9067

Closed
andersosthus opened this issue May 5, 2020 · 1 comment · Fixed by #9068
Closed

Comments

@andersosthus
Copy link
Contributor

kubernetes/kubernetes#39551 added two flags to control the attach-detach reconcile sync in kube-controller-manager, attach-detach-reconcile-sync-period and disable-attach-detach-reconcile-sync, but only one of them got added to Kops in #1465.

We currently have the need to set disable-attach-detach-reconcile-sync, so I suggest adding disable-attach-detach-reconcile-sync as an option alongside attach-detach-reconcile-sync-period to Kops.

I can contribute the changes needed, if this sounds ok.

@rifelpet
Copy link
Member

rifelpet commented May 5, 2020

Yes, feel free to open a PR! heres an example of a similar PR you can use as a reference. Essentially the field is added to pkg/apis/kops/v1alpha2/componentconfig.go and pkg/apis/kops/componentconfig.go and then you need to run make apimachinery crds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants