Switch AWS IAM Authenticator to use non-scratch image #8555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The authenticator binary uses glog which requires write access to the filesystem under /tmp On the scratch image /tmp doesnt exist which caused a crash loop: ``` time="2020-02-14T02:06:00Z" level=info msg="creating event broadcaster" time="2020-02-14T02:06:00Z" level=info msg="setting up event handlers" W0214 02:06:00.358119 1 client_config.go:539] Neither --kubeconfig nor --master was specified. Using the inClusterConfig. This might not work. log: exiting because of error: log: cannot create log: open /tmp/aws-iam-authenticator.ip-X-X-X-X.aws-iam-authenticator.log.WARNING.20200214-020600.1: no such file or directory ``` Switching to debian-stretch fixed the issue although it could really be any of the other images in the release [0] [0] https://github.com/kubernetes-sigs/aws-iam-authenticator/releases/tag/v0.5.0
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Feb 14, 2020
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 14, 2020
…pstream-release-1.16 Automated cherry pick of #8555: Switch AWS IAM Authenticator to use non-scratch image
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 14, 2020
…pstream-release-1.17 Automated cherry pick of #8555: Switch AWS IAM Authenticator to use non-scratch image
This was referenced Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authenticator binary uses glog which requires write access to the filesystem under /tmp.
On the scratch image /tmp doesnt exist which caused a crash loop:
Switching to debian-stretch fixed the issue although we could realistically use any of the other images in the release [0]
This will need cherry-picking back to 1.16 to match #8423 and its cherry-picks.
[0] https://github.com/kubernetes-sigs/aws-iam-authenticator/releases/tag/v0.5.0
Side note: I'd like this us to use authenticator in an e2e job but i believe it requires either a configmap or CRD so in additional to adding --override plumbing we'd need a way for the test to apply an arbitrary manifest. I'm not sure if thats supported by our prow jobs and kubetest, but I can look into it.