Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #8555: Switch AWS IAM Authenticator to use non-scratch image #8556

Conversation

hakman
Copy link
Member

@hakman hakman commented Feb 14, 2020

Cherry pick of #8555 on release-1.17.

#8555: Switch AWS IAM Authenticator to use non-scratch image

For details on the cherry pick process, see the cherry pick requests page.

The authenticator binary uses glog which requires write access to the filesystem under /tmp
On the scratch image /tmp doesnt exist which caused a crash loop:

```
time="2020-02-14T02:06:00Z" level=info msg="creating event broadcaster"
time="2020-02-14T02:06:00Z" level=info msg="setting up event handlers"
W0214 02:06:00.358119       1 client_config.go:539] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
log: exiting because of error: log: cannot create log: open /tmp/aws-iam-authenticator.ip-X-X-X-X.aws-iam-authenticator.log.WARNING.20200214-020600.1: no such file or directory
```

Switching to debian-stretch fixed the issue although it could really be any of the other images in the release [0]

[0] https://github.com/kubernetes-sigs/aws-iam-authenticator/releases/tag/v0.5.0
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Feb 14, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2020
@hakman hakman requested a review from rifelpet February 14, 2020 04:16
@hakman
Copy link
Member Author

hakman commented Feb 14, 2020

/test pull-kops-e2e-kubernetes-aws-1-17

@rifelpet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2020
@hakman
Copy link
Member Author

hakman commented Feb 14, 2020

/retest

1 similar comment
@hakman
Copy link
Member Author

hakman commented Feb 14, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0089dc0 into kubernetes:release-1.17 Feb 14, 2020
@hakman hakman deleted the automated-cherry-pick-of-#8555-upstream-release-1.17 branch February 24, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants