Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for +mapType, +structType #177

Closed
mariantalla opened this issue Nov 5, 2019 · 3 comments · Fixed by #178
Closed

Add support for +mapType, +structType #177

mariantalla opened this issue Nov 5, 2019 · 3 comments · Fixed by #178
Assignees

Comments

@mariantalla
Copy link
Contributor

The two annotations used to describe the topology of maps and structs, +mapType and +structType, should result in generating the equivalent openapi extensions (x-kubernetes-map-type and x-kubernetes-struct-type respectively). This is documented but not implemented at the moment.

/assign
(have a tiny PR in progress at the moment)

@sttts
Copy link
Contributor

sttts commented Nov 6, 2019

👍

@sttts
Copy link
Contributor

sttts commented Nov 6, 2019

Can you do the same addition to controller-tools? (compare kubernetes-sigs/controller-tools#345 for an example). I would like to make sure we use the same markers for both kube-openapi and kubebuilder's controller-tools.

cc @DirectXMan12

@mariantalla
Copy link
Contributor Author

Yep, coming up next (sorry, should have created an issue 🤦‍♀ will go ahead and do that now). Thanks for the pointer too 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants