diff --git a/pkg/customresourcestate/registry_factory.go b/pkg/customresourcestate/registry_factory.go index 15ebdcbe72..7f5c7d574d 100644 --- a/pkg/customresourcestate/registry_factory.go +++ b/pkg/customresourcestate/registry_factory.go @@ -72,6 +72,10 @@ func compileCommon(c MetricMeta) (*compiledCommon, error) { func compileFamily(f Generator, resource Resource) (*compiledFamily, error) { labels := resource.Labels.Merge(f.Labels) + if f.Each.Type == MetricTypeInfo && !strings.HasSuffix(f.Name, "_info") { + klog.InfoS("Info metric does not have _info suffix", "gvk", resource.GroupVersionKind.String(), "name", f.Name) + } + metric, err := newCompiledMetric(f.Each) if err != nil { return nil, fmt.Errorf("compiling metric: %w", err) diff --git a/pkg/metric_generator/generator.go b/pkg/metric_generator/generator.go index bf50c377cf..e1cce4906d 100644 --- a/pkg/metric_generator/generator.go +++ b/pkg/metric_generator/generator.go @@ -21,7 +21,6 @@ import ( "strings" basemetrics "k8s.io/component-base/metrics" - "k8s.io/klog/v2" "k8s.io/kube-state-metrics/v2/pkg/metric" ) @@ -74,10 +73,6 @@ func (g *FamilyGenerator) Generate(obj interface{}) *metric.Family { family := g.GenerateFunc(obj) family.Name = g.Name family.Type = g.Type - // OpenMetrics spec requires that all Info metrics have a _info suffix. - if family.Type == metric.Info && !strings.HasSuffix(family.Name, "_info") { - klog.InfoS("Info metric %s does not have _info suffix", family.Name) - } return family }