Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exitcode to labels of kube_pod_init_container_status_terminated_reason #1481

Closed
dafenko opened this issue May 14, 2021 · 13 comments
Closed
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@dafenko
Copy link

dafenko commented May 14, 2021

What would you like to be added:
Add exitcode to labels of kube_pod_init_container_status_terminated_reason

Why is this needed:
Our application has defined exit codes. We would like to be alerted when app ends up with a specified error code.

Describe the solution you'd like
We would like to define alert that uses kube_pod_init_container_status_terminated_reason metric and be alerted when container exists with certain exit code.

Additional context
We are using node.js. Node.js has limit for memory allocation. (see NODE_OPTIONS --max-old-space-size=)
We intentionally keep limit for node.js a few percent less then K8S resource limit.
In that way node.js has possibility to handle OOM (e.g. create dump file).
POD gets then signal SIGABRT 6 (exit code 128+6 = 134).
We would like to be alerted when such situation happens.

@dafenko dafenko added the kind/feature Categorizes issue or PR as related to a new feature. label May 14, 2021
@slashpai
Copy link
Contributor

slashpai commented Jun 8, 2021

I would like to work on this. I will review and update back

/assign

@dannylee-
Copy link

Would it be better to create a new metric with the exit code? Or else we would introduce a label with a large cardinality (256 possible values)

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 11, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 10, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prashantv
Copy link

/reopen

Having exit code would be useful for monitoring different types of container exits.

@k8s-ci-robot
Copy link
Contributor

@prashantv: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Having exit code would be useful for monitoring different types of container exits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fgiannetti
Copy link

I would like to work on this. I will review and update back

/assign

Hey @slashpai
Have some news about this? It would be really useful to have this feature ;)
Or maybe this message will reopen this issue...
Thank you!!

@ssabo ssabo mentioned this issue Jun 8, 2022
@ssabo
Copy link
Contributor

ssabo commented Jun 8, 2022

/reopen

@k8s-ci-robot
Copy link
Contributor

@ssabo: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anatoli-klamer
Copy link

/reopen

@k8s-ci-robot
Copy link
Contributor

@anatoli-klamer: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

9 participants