Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ready replicas metric for deployments #1522

Closed
akshitgrover opened this issue Jul 6, 2021 · 2 comments · Fixed by #1534
Closed

Add Ready replicas metric for deployments #1522

akshitgrover opened this issue Jul 6, 2021 · 2 comments · Fixed by #1534
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@akshitgrover
Copy link
Contributor

What would you like to be added:
Ready Replicas count for the deployment object is missing from the list and is absent from the source code as well
I'd like this to be reported like all other metrics for deployments eg: desired, available replicas etc.

Why is this needed:
Ready Replicas count is an insightful metric as it depicts the number of traffic serving pods for a particular deployment, This can be used in number of ways to compare across the board for troubleshooting

Describe the solution you'd like
The solution is quite simple, We'll just need to add one more metric generator inside 'deploymentMetricFamilies' method using the deployment.Status.ReadyReplicas field

Additional context
None

@akshitgrover akshitgrover added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 6, 2021
@akshitgrover
Copy link
Contributor Author

I'd like to work on this as well
I hope it's fine @mrueg @brancz
/assign

@akshitgrover
Copy link
Contributor Author

Does this need triage like issues in Kubernetes main repo?
cc @mrueg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant