Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uid as label to service metrics #1686

Closed
jhorwit2 opened this issue Feb 16, 2022 · 1 comment · Fixed by #1687
Closed

Add uid as label to service metrics #1686

jhorwit2 opened this issue Feb 16, 2022 · 1 comment · Fixed by #1687
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jhorwit2
Copy link

What would you like to be added:

Add UID as a label, like it is on some other metrics, to all service metrics.

Why is this needed:

This is valuable since load balancer services in clouds often use the UID as the name of the cloud load balancer; however, there's no easy way then to join those metrics in say grafana given the uid is not available by kube state. Making UID available as a field would make this possible

Describe the solution you'd like

Additional context

@jhorwit2 jhorwit2 added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 16, 2022
@fpetkovski fpetkovski added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 17, 2022
@liangyuanpeng
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants