Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomResourceState move from GroupVersionKind to GroupVersionResource #2093

Open
mrueg opened this issue Jun 8, 2023 · 3 comments
Open
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@mrueg
Copy link
Member

mrueg commented Jun 8, 2023

What would you like to be added:
Currently the configuration requires to set a Group, a Version and a Kind, CRS should either move to or additionally accept a Group Version Resource option.
Why is this needed:
We run into issues with pluralizing the kind and if we use resources, we also can generate RBAC roles from the existing CRS config without figuring out what resource we need to attach it to.
Describe the solution you'd like

Ideally we drop the Kind and make it GroupVersionResource to limit the scope effectively. This is breaking existing configs, but it's an experimental feature, so we can still iterate on it.

Additional context

@mrueg mrueg added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 8, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 8, 2023
@logicalhan
Copy link
Member

great!

/triage accepted
/assign @rexagod

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 15, 2023
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jun 14, 2024
@rexagod
Copy link
Member

rexagod commented Jun 14, 2024

It makes sense to acknowledge the resolution on kubernetes-sigs/kubebuilder#3402 and not make them dependent on the "broken" pluralization logic upstream. Both of these places have procedures, albeit differing in nature, which if modified will have far-reaching repercussions.

Practically, any repository should follow the conventions set by its upstream to persist similar expectations across the ecosystem, however, if that should still be the case if the "conventions" (pluralization logic in k/k) are less than ideal is a grey area in itself.

IMHO we probably should stick to flect, since apimachinery acknowledges the procedure is broken, and implicitly, as I'm assuming, discourages depending on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

5 participants