Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: include pod annotations #826

Closed
sayarg opened this issue Jul 17, 2019 · 4 comments
Closed

Feature request: include pod annotations #826

sayarg opened this issue Jul 17, 2019 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sayarg
Copy link

sayarg commented Jul 17, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened:

Hi

There have been a few requests in the past to add annotations, they seem to have been left to rotten and were closed. Are there any current plans to add pod annotations? Alternatively, would you be supportive of a PR to optionally enable annotations on pods.

Found these issues with similar requests: #574, #250

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 17, 2019
@tariq1890
Copy link
Contributor

tariq1890 commented Jul 17, 2019

See this comment by @brancz in PR #770. The pod annotations were excluded because of a potential high cardinality.

@sayarg
Copy link
Author

sayarg commented Jul 18, 2019

Hi @tariq1890 will it be supported? I had a notification about a comment from you that it is part of 1.7 and is in the rc, but I don't see the comment. Or have you decided to not include pod in the annotation feature?

@tariq1890
Copy link
Contributor

@sayarg I commented that by mistake (sorry :() which is why I had deleted it. It will not be supported.

@sayarg
Copy link
Author

sayarg commented Jul 19, 2019

hi @tariq1890 no worries. how about enabling only for selected annotations? in the config you'd need to opt in the exact annotations you wish to report, to avoid the scale issue and specifically the annotation that is used to keep trail of pod changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants