Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Remove deprecated metrics #974

Closed
lilic opened this issue Dec 4, 2019 · 4 comments · Fixed by #1004
Closed

v2: Remove deprecated metrics #974

lilic opened this issue Dec 4, 2019 · 4 comments · Fixed by #1004
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. v2 version 2

Comments

@lilic
Copy link
Member

lilic commented Dec 4, 2019

For the breaking v2 release we want remove all the metrics that have been marked as DEPRECATED.

Blocked until after release v1.9.0.

@lilic lilic added v2 version 2 help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Dec 4, 2019
@tariq1890 tariq1890 added this to the kube-state-metrics v2.0.0 milestone Dec 4, 2019
@yeya24
Copy link
Contributor

yeya24 commented Dec 13, 2019

Hello @lilic, can I work on this?

@yeya24
Copy link
Contributor

yeya24 commented Dec 13, 2019

One question about it.
In https://github.com/kubernetes/kube-state-metrics/blob/master/docs/README.md, there are some metrics marked as deprecated. But in https://github.com/kubernetes/kube-state-metrics/blob/master/docs/node-metrics.md I found there is a metric kube_node_status_phase marked as deprecated, but it is not in the previous doc. So is this metric deprecated? Do we need to remove it as well?

@lilic
Copy link
Member Author

lilic commented Dec 13, 2019

/assign @yeya24

Go ahead, thanks!

Yes lets remove all that are deprecated, maybe the docs are not matched.

@yeya24
Copy link
Contributor

yeya24 commented Dec 13, 2019

@lilic Thanks.
Another question: Do we still need the two options after removing the deprecated metrics? I guess I need to remove them as well?

	if opts.DisablePodNonGenericResourceMetrics {
		whiteBlackList.Exclude([]string{
			"kube_pod_container_resource_requests_cpu_cores",
			"kube_pod_container_resource_requests_memory_bytes",
			"kube_pod_container_resource_limits_cpu_cores",
			"kube_pod_container_resource_limits_memory_bytes",
		})
	}

	if opts.DisableNodeNonGenericResourceMetrics {
		whiteBlackList.Exclude([]string{
			"kube_node_status_capacity_cpu_cores",
			"kube_node_status_capacity_memory_bytes",
			"kube_node_status_capacity_pods",
			"kube_node_status_allocatable_cpu_cores",
			"kube_node_status_allocatable_memory_bytes",
			"kube_node_status_allocatable_pods",
		})
	}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. v2 version 2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants