Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Rename --namespace flag to --namespaces #978

Closed
lilic opened this issue Dec 4, 2019 · 6 comments · Fixed by #1098
Closed

v2: Rename --namespace flag to --namespaces #978

lilic opened this issue Dec 4, 2019 · 6 comments · Fixed by #1098
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. v2 version 2

Comments

@lilic
Copy link
Member

lilic commented Dec 4, 2019

Rename the CLI flag namespace to namespaces.

The merging of this is blocked until after the v1.9.0 release.

@lilic lilic added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. v2 version 2 labels Dec 4, 2019
@raunaqness
Copy link

Hey @lilic. Can I take this up?

@lilic
Copy link
Member Author

lilic commented Dec 11, 2019

@raunaqness go for it! Thanks! Note that it won’t be merged until the current release candidate is released. So a week or two. :)

/assign @raunaqness

@raunaqness
Copy link

@lilic Thanks!
I'm a little new to open source contribution, can you guide me a little bit about where I should start looking for to make the changes for this?

@lilic
Copy link
Member Author

lilic commented Dec 11, 2019

Just search wherever it says namespace in CLI flags and rename to namespaces. https://github.com/kubernetes/kube-state-metrics/blob/master/pkg/options/options.go#L88

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 10, 2020
@lilic
Copy link
Member Author

lilic commented Mar 10, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. v2 version 2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants