Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PodDisruptionBudget metrics #551

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Conversation

gregory-lyons
Copy link

What this PR does / why we need it:
Adds metrics for PodDisruptionBudget

Which issue(s) this PR fixes :
Fixes #546

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 2, 2018
@k8s-ci-robot k8s-ci-robot requested review from brancz and zouyee October 2, 2018 05:02
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 2, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 2, 2018
@gregory-lyons gregory-lyons force-pushed the pdb branch 2 times, most recently from 73aef58 to cb29cbc Compare October 2, 2018 19:21
@gregory-lyons
Copy link
Author

anyone get a chance to look at this?

@brancz
Copy link
Member

brancz commented Oct 15, 2018

Did you have a chat with @mxinden about rebasing this on top of his in-progress architecture changes?

@gregory-lyons
Copy link
Author

I mentioned it here: #546 (comment)

If the architecture changes are close to merge, I can rebase. @mxinden what's the current status?

@mxinden
Copy link
Contributor

mxinden commented Oct 16, 2018

@gregory-lyons #534 merged today. Let me know if I can help you adapting to the changes. I a sorry for the inconvenience.

@gregory-lyons
Copy link
Author

@mxinden @brancz I've now rebased on top of #534

@brancz
Copy link
Member

brancz commented Oct 18, 2018

/lgtm sorry for the delay, and thanks for bearing with us :)

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2018
Copy link
Contributor

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will follow up fixing the TODO comments in general for all collectors. Thanks for rebasing!

@gregory-lyons
Copy link
Author

@brancz anything else I need to do on my end to get this merged? Thanks for review

@brancz
Copy link
Member

brancz commented Oct 19, 2018

Actually not sure why it didn’t merge it.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, gregory-lyons

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a166def into kubernetes:master Oct 19, 2018
dghubble added a commit to poseidon/typhoon that referenced this pull request Jan 22, 2019
* Update kube-state-metrics ClusterRole to allow collecting
poddisruptionbudget metrics (exported as kube_poddisruptionbudget_*)
* kubernetes/kube-state-metrics#551
* Bump addon-resizer from v1.7 to v1.8.4
dghubble added a commit to poseidon/typhoon that referenced this pull request Jan 22, 2019
* Update kube-state-metrics ClusterRole to allow collecting
poddisruptionbudget metrics (exported as kube_poddisruptionbudget_*)
* kubernetes/kube-state-metrics#551
* Bump addon-resizer from v1.7 to v1.8.4
dghubble added a commit to poseidon/typhoon that referenced this pull request Jan 22, 2019
* Update kube-state-metrics ClusterRole to allow collecting
poddisruptionbudget metrics (exported as kube_poddisruptionbudget_*)
* kubernetes/kube-state-metrics#551
* Bump addon-resizer from v1.7 to v1.8.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics for PodDisruptionBudget objects
4 participants