-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PodDisruptionBudget metrics #551
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
73aef58
to
cb29cbc
Compare
anyone get a chance to look at this? |
Did you have a chat with @mxinden about rebasing this on top of his in-progress architecture changes? |
I mentioned it here: #546 (comment) If the architecture changes are close to merge, I can rebase. @mxinden what's the current status? |
@gregory-lyons #534 merged today. Let me know if I can help you adapting to the changes. I a sorry for the inconvenience. |
/lgtm sorry for the delay, and thanks for bearing with us :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will follow up fixing the TODO
comments in general for all collectors. Thanks for rebasing!
@brancz anything else I need to do on my end to get this merged? Thanks for review |
Actually not sure why it didn’t merge it. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, gregory-lyons The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update kube-state-metrics ClusterRole to allow collecting poddisruptionbudget metrics (exported as kube_poddisruptionbudget_*) * kubernetes/kube-state-metrics#551 * Bump addon-resizer from v1.7 to v1.8.4
* Update kube-state-metrics ClusterRole to allow collecting poddisruptionbudget metrics (exported as kube_poddisruptionbudget_*) * kubernetes/kube-state-metrics#551 * Bump addon-resizer from v1.7 to v1.8.4
* Update kube-state-metrics ClusterRole to allow collecting poddisruptionbudget metrics (exported as kube_poddisruptionbudget_*) * kubernetes/kube-state-metrics#551 * Bump addon-resizer from v1.7 to v1.8.4
What this PR does / why we need it:
Adds metrics for PodDisruptionBudget
Which issue(s) this PR fixes :
Fixes #546