Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alllow user to provide the certificate key on upload-certs #1408

Closed
yagonobre opened this issue Feb 13, 2019 · 6 comments · Fixed by kubernetes/kubernetes#74671
Closed

Alllow user to provide the certificate key on upload-certs #1408

yagonobre opened this issue Feb 13, 2019 · 6 comments · Fixed by kubernetes/kubernetes#74671
Assignees
@yagonobre
Labels
area/HA area/UX kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@yagonobre
Copy link
Member

  • Add the --certificate-key flag to upload-certs phase, so user can provide the certificate
  • Add the --skip-certificate-key-print flag to avoid printing the key

/area ha
/area ux
/kind feature
/priority important-soon
/lifecycle active
@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. area/HA area/UX kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 13, 2019
@yagonobre yagonobre mentioned this issue Feb 13, 2019
Closed
25 tasks
@yagonobre
Copy link
Member Author

/assign

@RA489
Copy link
Contributor

RA489 commented Feb 18, 2019

@yagonobre Can i help on this?

@yagonobre yagonobre mentioned this issue Feb 18, 2019
Merged
4 tasks
@yagonobre
Copy link
Member Author

Hey @RA489, sorry but I already have a pr for it, I'm just waiting the base pr get merged.

@RA489
Copy link
Contributor

RA489 commented Feb 18, 2019

@yagonobre Thanks for the info.

@rosti
Copy link

rosti commented Feb 26, 2019

@yagonobre should we close this one?

@yagonobre
Copy link
Member Author

@rosti not yet, I'll send the pr tomorrow.

@neolit123 neolit123 mentioned this issue Feb 27, 2019
Closed
@yagonobre yagonobre mentioned this issue Feb 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yagonobre yagonobre

Labels
area/HA area/UX kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add certificate-key to kubeadm upload-certs phase, and improve init output yagonobre/kubernetes
4 participants
@rosti @yagonobre @k8s-ci-robot @RA489