-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade complains of not migratable CoreDns plugin grpc #2830
Comments
this is coredns specific and we cannot do much on the kubeadm side. |
Oh, I see. Should I close this one then and reopen it somewhere else? |
the migration tool is here: but let's wait for feedback first. |
Thanks. The migration tool only supports plugins used in the default k8s deployment and a few common plugins. Grpc is not one of them. |
You should not need to remove the plugin and add it back. Unsupported plugins are left in the corefile unmodified. The warning is there just to let you know that the migration tool is not actively migrating grpc in case there was a backward incompatible change to the unsupported plugin’s configuration (eg deprecated options). You can probably ignore the warning. |
thanks @chrisohaver closing given the warning can be just ignored. |
It is odd though that kubeadm raises migration warnings when the target version is the same as the current version. |
i think kubeadm would ask the migration lib if migration is possible from ver x to y (or in this case from x to x). perhaps migration warnings should be ignored if coredns versions are the same, or the migration lib should not return the warnings. |
Yes, the migration lib should check to see if it has been called with a nonsense migration. But it's still odd that kubeadm would bother asking the migration lib anything, if it knows it is not upgrading CoreDNS. |
It sounds like a small bug that we can fix. I will try to fix it. Or migration from same versions can skip. I need take a deep look. |
Yes, that was my thinking, too. I add |
Let me know, if there is anything I can test. It's easy for me to revert back and forth since my cluster is lokal and fully virtualized. |
FYI, fix here in migration lib: coredns/corefile-migration#75 |
@chrisohaver Awesome! I like things done that swiftly! ;-) |
Ive made the fix in the lib, and adjusted tests. There's a very slim possibility that someone may be using the |
|
Is this a BUG REPORT or FEATURE REQUEST?
Choose one: BUG REPORT
Versions
kubeadm version (use
kubeadm version
): 1.25.3Environment:
kubectl version
): 1.25.3uname -a
): Linux master0.k8s 5.10.0-20-amd64 kubeadm join on slave node fails preflight checks #1 SMP Debian 5.10.158-2 (2022-12-13) x86_64 GNU/LinuxWhat happened?
Creating an upgrade plan with kubeadm says:
[WARNING CoreDNSUnsupportedPlugins]: CoreDNS cannot migrate the following plugins:
[Plugin "grpc" is unsupported by this migration tool in 1.9.3.]
What you expected to happen?
Flawless migration plan to be executable.
How to reproduce it (as minimally and precisely as possible)?
Create a cluster running kubernetes 1.25.3 (or earlier).
Add grpc to CoreDns config.
My current config looks like this:
apt-get update
apt upgrade
kubeadem upgrade plan
Anything else we need to know?
Here's more what I get during the upgrade.
The text was updated successfully, but these errors were encountered: