-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm init --token is only respected if its the sole flag #325
Comments
Can you share you /etc/kubernetes/kubeadm.conf file? |
This is working as expected and documented. |
@luxas I was able to reproduce this behavior with the following kubeadm.conf file: apiVersion: kubeadm.k8s.io/v1alpha1
kind: MasterConfiguration
selfHosted: false The token passed to |
@gtirloni sure, it is the basic one.
@luxas you're not wrong in that appending Please reopen. |
That's a design decision.
|
@luxas I think if I'm getting it correctly is that the config file takes precedence. I agree with that as a design decision. What I'm saying is that up until this latest version if you specified something like the token via a flag that did not exist in the config file, it would get picked up. That is both intuitive and documented. An example like that is given in the docs and was working last week. If the change is now that if a config file is specified at all no other flag is respected, that's also fine, but then at least the documentation needs to reflect this. |
@Zilman Interesting. Which |
Is this a BUG REPORT or FEATURE REQUEST?
BUG REPORT
Versions
kubeadm version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.6", GitCommit:"7fa1c1756d8bc963f1a389f4a6937dc71f08ada2", GitTreeState:"clean", BuildDate:"2017-06-16T18:21:54Z", GoVersion:"go1.7.6", Compiler:"gc", Platform:"linux/amd64"}
Environment:
kubectl version
):Client Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.6", GitCommit:"7fa1c1756d8bc963f1a389f4a6937dc71f08ada2", GitTreeState:"clean", BuildDate:"2017-06-16T18:34:20Z", GoVersion:"go1.7.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.6", GitCommit:"7fa1c1756d8bc963f1a389f4a6937dc71f08ada2", GitTreeState:"clean", BuildDate:"2017-06-16T18:21:54Z", GoVersion:"go1.7.6", Compiler:"gc", Platform:"linux/amd64"}
uname -a
): Linux ip-172-20-0-211 3.10.0-514.21.2.el7.x86_64 kubeadm join on slave node fails preflight checks #1 SMP Tue Jun 20 12:24:47 UTC 2017 x86_64 x86_64 x86_64 GNU/LinuxWhat happened?
What you expected to happen?
How to reproduce it (as minimally and precisely as possible)?
kubeadm init --token=${TOKEN} --config=/etc/kubernetes/kubeadm.conf
Anything else we need to know?
kubeadm init --token=${TOKEN}
works as expected.Anything else we need to know?
I'm not sure if this is by design or not. I believe I was able to use two flags with kubeadm init just a few days ago, so perhaps this is a regression with kubeadm 1.6.6.
The text was updated successfully, but these errors were encountered: