Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl debug: allow users to specify debugging profile #1108

Open
1 of 7 tasks
knight42 opened this issue Sep 10, 2021 · 13 comments
Open
1 of 7 tasks

kubectl debug: allow users to specify debugging profile #1108

knight42 opened this issue Sep 10, 2021 · 13 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@knight42
Copy link
Member

knight42 commented Sep 10, 2021

This is the tracking issue for the implementation of debugging profile feature of kubectl debug.
Ref: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cli/1441-kubectl-debug#debugging-profiles

There are multiple profiles that we need to handle, and I plan to file a single PR for each profile:

/assign

@knight42 knight42 added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 10, 2021
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 10, 2021
@knight42
Copy link
Member Author

@verb I am not certain about what isolated namespaces and private namespaces actually means, could you please elaborate more on them? What is the difference between them?

@verb
Copy link
Contributor

verb commented Sep 10, 2021

/triage accepted
/cc @verb

@knight42 I like that you're planning on implementing the profiles incrementally. iirc the namespaces are referring to shareProcessNamespace.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 10, 2021
@verb
Copy link
Contributor

verb commented Sep 24, 2021

/assign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 23, 2021
@verb
Copy link
Contributor

verb commented Jan 3, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2022
@verb
Copy link
Contributor

verb commented Mar 14, 2022

@knight42 what's your availability to work on the general profile? I have some time to start working on it, too.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 10, 2022
@alexku7
Copy link

alexku7 commented Sep 14, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 14, 2022
@alexku7
Copy link

alexku7 commented Nov 18, 2022

any update on that issue? The ability to attach the debug container with elevated capabilities is very very welcome :)

@wedaly
Copy link
Contributor

wedaly commented Dec 15, 2022

I created a branch that implements the "netadmin" profile, but it depends on changes in kubernetes/kubernetes#114280, so I'll wait until that one is merged before opening a PR.

The branch is here: kubernetes/kubernetes@master...wedaly:kubernetes:kubectl-netadmin-debug-profile (netadmin implemented in the last commit)

@sding3
Copy link
Contributor

sding3 commented Feb 9, 2023

I created a branch that implements the "netadmin" profile, but it depends on changes in kubernetes/kubernetes#114280, so I'll wait until that one is merged before opening a PR.

The branch is here: kubernetes/kubernetes@master...wedaly:kubernetes:kubectl-netadmin-debug-profile (netadmin implemented in the last commit)

@wedaly - 114280 has merged.

@mochizuki875
Copy link
Member

Is there any reason why sysadmin has not be implemented?
If no reason, I'll try to do it.

@mochizuki875
Copy link
Member

I've created PR that implements auto profile.
kubernetes/kubernetes#120687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

8 participants