Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment status #17164

Closed
bgrant0607 opened this issue Nov 12, 2015 · 4 comments
Closed

Deployment status #17164

bgrant0607 opened this issue Nov 12, 2015 · 4 comments
Assignees
Labels
area/app-lifecycle area/kubectl priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@bgrant0607
Copy link
Member

Status:

  • Number of pods of each version
  • Number ready/not ready (should add to RC also)

cc @nikhiljindal @janetkuo @ironcladlou @ncdc

@bgrant0607 bgrant0607 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/app-lifecycle area/kubectl team/ux labels Nov 12, 2015
@bgrant0607 bgrant0607 added this to the v1.2-candidate milestone Nov 12, 2015
@bgrant0607 bgrant0607 modified the milestones: v1.2-candidate, v1.2 Nov 19, 2015
@bgrant0607
Copy link
Member Author

And we still need to add a /status subresource.
https://github.com/kubernetes/kubernetes/blob/master/pkg/master/master.go

@0xmichalis
Copy link
Contributor

And we still need to add a /status subresource.

There is already one

storage["deployments/status"] = deploymentStorage.Status

// StatusREST implements the REST endpoint for changing the status of a deployment
type StatusREST struct {
store *etcdgeneric.Etcd
}
func (r *StatusREST) New() runtime.Object {
return &extensions.Deployment{}
}
// Update alters the status subset of an object.
func (r *StatusREST) Update(ctx api.Context, obj runtime.Object) (runtime.Object, bool, error) {
return r.store.Update(ctx, obj)
}

@0xmichalis
Copy link
Contributor

Why do we need to have the number of each version in the deployment status?

@bgrant0607
Copy link
Member Author

@Kargakis I agree that the number of pods of the latest revision is good enough, at least for now.

We also have available/unavailable.

We can make changes or add more based on user feedback.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-lifecycle area/kubectl priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants