Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube image save should assume docker.io if not specified #19233

Closed
medyagh opened this issue Jul 10, 2024 · 1 comment · Fixed by #19312
Closed

minikube image save should assume docker.io if not specified #19233

medyagh opened this issue Jul 10, 2024 · 1 comment · Fixed by #19312
Assignees
@ComradeProgrammer
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@medyagh
Copy link
Member

medyagh commented Jul 10, 2024 •
edited
Loading

when playing with this PR I figured out I had to prefix docker.io to make image save and load from file test pass

https://github.com/kubernetes/minikube/pull/19229/files
@medyagh medyagh added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 10, 2024
@ComradeProgrammer ComradeProgrammer self-assigned this Jul 21, 2024
@ComradeProgrammer
Copy link
Member

/assign

@ComradeProgrammer ComradeProgrammer mentioned this issue Jul 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ComradeProgrammer ComradeProgrammer

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix empty tarball when generating image save ComradeProgrammer/minikube
2 participants
@medyagh @ComradeProgrammer