minikube cache add, doesn't add to other profiles unless restart

[medyagh]

Here is how to reproduce:

start two minikube profiles

minikube start
minikube start -p p1

tag an image and add it to the cache

medya@~ $ docker tag alpine justforfun
medya@~ $ minikube cache add justforfun

ssh into minikube and see the images

medya@~ $ minikube ssh -p p1 docker images | grep justforfun
medya@~ $ minikube ssh -p minikube docker images | grep justforfun
justforfun                                latest              965ea09ff2eb        5 weeks ago         5.55MB

as we see the cached image was loaded to minikube profile but not p1

however if we restart p1, it will pick up the cached image

[medyagh]

So the current behavior is, it loads image to the default profile without restart but for other profiles you need to restart.

What I suggest is this
Either

• minikube cache add img, loads the image to all profiles

Or

• minikube cache add be be bound to a profile only ! and if you add an image using this command only be lodaded from that profile (as opposed to to all profiles on restart)

What do you guys think?
@afbjorklund @tstromberg

[afbjorklund]

It's probably fine if it loads to the current profile only, but confusing if it does load to the others but isn't visible right away... That sounds like a bug, or at least something that was unintended ?

[medyagh]

hm...for the PR I tried to keep the current behaviour.

[tstromberg]

@medyagh - was this fixed?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[sharifelgamal]

This is fixed.