Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rkt: bump to 1.24.0 #1128

Merged
merged 1 commit into from
Feb 15, 2017
Merged

rkt: bump to 1.24.0 #1128

merged 1 commit into from
Feb 15, 2017

Conversation

dongsupark
Copy link
Contributor

As rkt 1.24.0 supports an experimental attach command, minikube iso image should also contain the new version.

See also rkt/rkt#3396 (comment)
/cc @s-urbaniak

As rkt 1.24.0 supports an experimental attach command, minikube iso
image should also contain the new version.

See also rkt/rkt#3396 (comment)
/cc @s-urbaniak
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2017
@dongsupark
Copy link
Contributor Author

I've also tested with "make minikube_iso". rkt 1.24 gets included in the iso image.

@s-urbaniak
Copy link

LGTM, thanks!

Note that rkt attach is not integrated in k8s itself at this point.

@codecov-io
Copy link

Codecov Report

Merging #1128 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1128   +/-   ##
=======================================
  Coverage   31.59%   31.59%           
=======================================
  Files          45       45           
  Lines        2114     2114           
=======================================
  Hits          668      668           
  Misses       1314     1314           
  Partials      132      132

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072ccdc...91e023a. Read the comment docs.

Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for upgrading this!

@r2d4 r2d4 merged commit cc8ca66 into kubernetes:master Feb 15, 2017
@dongsupark dongsupark deleted the dongsu/bump-rkt-1.24 branch February 23, 2017 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants