-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please create kubernetes/klog (for forking glog) #195
Comments
Also started an email thread in sig-arch: |
/lgtm |
Are we still intending for this to be a transitional step towards our logging end goal? If so, can we call that out in the description & readme, and discourage others from using this? My concern is that as soon as we put out a "kubernetes-log" repo, other projects will start cargo-culting it... |
hey @dims, can you ping me back on this when consensus at sig-arch has been achieved? Then I can coordinate with you on a repo transfer. |
Will do. thanks @cblecker. I am going to assume @thockin and @tallclair are approvers on the plan from @kubernetes/sig-architecture-feature-requests |
/sig instrumentation |
@kubernetes/sig-architecture-feature-requests @thockin @bgrant0607 @tallclair @justinsb sig-arch folks, please +1 this request |
/lgtm |
2 similar comments
/lgtm |
/lgtm |
Very interested in seeing this happen -- Minor note about glog vs klog, |
@dims thoughts on @BenTheElder's comment? |
/lgtm |
@BenTheElder @thockin |
/assign @cblecker |
@dims So this isn't going to be a staging repo, right? Just moving over your existing fork? If so, can you please add me as an admin of the existing repo. |
Ack @cblecker doing that now |
/lgtm |
1 similar comment
/lgtm |
/lgtm |
@tallclair affirmative! will do |
This is moved into https://github.com/kubernetes/klog . Haven't fully finished all the automation pieces, but it's in progress :) |
hm, so we forked glog in https://github.com/kubernetes/klog, but forked yaml in https://github.com/kubernetes-sigs/yaml. 🤔 @dims @cblecker what was the reason for the separate orgs for these brand new forks? |
@neolit123 that was my call. |
@dims Can you add this to sigs.yaml? Then we can close this out. |
New Repo, Staging Repo, or migrate existing
Import https://github.com/dims/klog into kubernetes org
Requested name for new repository
klog
Which Organization should it reside
kubernetes
If not a staging repo, who should have admin access
@dims @thockin
If not a staging repo, who should have write access
@tallclair @justinsb, @erictune @lavalamp
If a new repo, who should be listed as approvers in OWNERS
@tallclair @justinsb, @erictune @lavalamp @dims @thockin
If a new repo, who should be listed in SECURITY_CONTACTS
@dims @thockin
What should the repo description be
Leveled execution logs for Go (fork of https://github.com/golang/glog)
What SIG and subproject does this fall under in sigs.yaml
sig-architecture
Approvals
Please prove you have followed the appropriate approval process for this new
repo by including links to the relevant approvals (meeting minutes, e-mail
thread, etc.)
Discussion in sig-arch on Oct 25, 2018 ( http://bit.ly/sig-architecture )
Authoritative requirements are here: https://git.k8s.io/community/github-management/kubernetes-repositories.md
tl;dr (but really you should read the linked doc, this may be stale)
in that SIG's charter
Additional context for request
Any additional information or context to describe the request.
/area github-repo
The text was updated successfully, but these errors were encountered: