Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped publishing /bin folders of CI builds #1227

Closed
Rajalakshmi-Girish opened this issue Apr 2, 2020 · 4 comments · Fixed by #1228
Closed

Stopped publishing /bin folders of CI builds #1227

Rajalakshmi-Girish opened this issue Apr 2, 2020 · 4 comments · Fixed by #1228
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release.
Milestone

Comments

@Rajalakshmi-Girish
Copy link

What happened:

"/bin" folder is not published in CI builds. This broke all the kubeadm master jobs.

https://testgrid.k8s.io/sig-release-master-informing#kubeadm-kinder-master

What you expected to happen:

The CI builds published should contain bin folder with the executables.

How to reproduce it (as minimally and precisely as possible):

Look for bin folder in
https://console.cloud.google.com/storage/browser/kubernetes-release-dev/ci/v1.19.0-alpha.1.247%2B2fd8debe9b913f

Anything else we need to know?:

Environment:

  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Others:
@Rajalakshmi-Girish Rajalakshmi-Girish added area/release-eng Issues or PRs related to the Release Engineering subproject kind/bug Categorizes issue or PR as related to a bug. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Apr 2, 2020
@justaugustus justaugustus added this to the v1.19 milestone Apr 2, 2020
@justaugustus
Copy link
Member

FYI @kubernetes/ci-signal @kubernetes/release-engineering
ref: https://kubernetes.slack.com/archives/C2C40FMNF/p1585845311247000

@justaugustus
Copy link
Member

This could be related to yesterday's change to lib/releaselib.sh in #1199, which would affect the push-build.sh script (which sources that library). push-build.sh pushes the build results of the ci-kubernetes-build* jobs, which are the artifacts that are pulled in several of our e2e tests.

I don't have time to look at this at the moment, but that (^^) should give people some places to start looking at and I'll sync up with the team later.

@justaugustus
Copy link
Member

Potentially this line

mapfile -t platforms < <(find "${release_stage}/client" -maxdepth 1 -mindepth 1 -type f -exec basename {} \;)

@justaugustus justaugustus added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Apr 2, 2020
@justaugustus
Copy link
Member

/assign @hasheddan @justaugustus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants