Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The failure caused by the newly added tests might be skipped #2148

Closed
dchen1107 opened this issue Mar 6, 2017 · 2 comments
Closed

The failure caused by the newly added tests might be skipped #2148

dchen1107 opened this issue Mar 6, 2017 · 2 comments

Comments

@dchen1107
Copy link
Member

While looking into kubernetes/kubernetes#42597, I found surprisely while the test failed, but testgrid still reports it passed:

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-kops-aws/5097

Looks like it might be the regression caused by #2142
@ixdy
Copy link
Member

ixdy commented Mar 6, 2017

I think that might be intentional - we re-run tests if they fail, and only fail the run if they fail every time, rather than flaking once.

@ixdy
Copy link
Member

ixdy commented Mar 6, 2017

https://github.com/kubernetes/kubernetes/blob/aa454ec740ed8985df2a07d2966c69e8adcc023b/hack/ginkgo-e2e.sh#L33-L34

Some jobs (e.g. ci-kubernetes-e2e-kops-aws set GINKGO_TOLERATE_FLAKES=y).

@fejta fejta closed this as completed Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fejta @dchen1107 @ixdy