Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: cgroup v2 node pool in community clusters #31572

Closed
AkihiroSuda opened this issue Jan 8, 2024 · 9 comments
Closed

Request: cgroup v2 node pool in community clusters #31572

AkihiroSuda opened this issue Jan 8, 2024 · 9 comments
Labels
sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@AkihiroSuda
Copy link
Member

Currently k8s-infra-prow-build and eks-prow-build-cluster are still using cgroup v1, although many users should have already switched to cgroup v2.
It is still possible to create a custom cluster with Boskos, but this is often complicated and hard to test on laptop.

Any chance to have cgroup v2 node pool in community clusters, or just have a new cluster dedicated for cgroup v2?

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 8, 2024
@AkihiroSuda
Copy link
Member Author

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 8, 2024
@ameukam
Copy link
Member

ameukam commented Jan 10, 2024

cc @BenTheElder

@kannon92
Copy link
Contributor

In a sig-node meeting a few weeks back, we did talk about making cgroups v2 the default. cc @dchen1107 @SergeyKanzhelev

It is possible to get a cgroupv2 cluster but you may have to target it specifically. We have examples of cgroupv2 jobs.

@BenTheElder
Copy link
Member

This is also
/sig k8s-infra

We have kubernetes/k8s.io#5276

In a sig-node meeting a few weeks back, we did talk about making cgroups v2 the default. cc @dchen1107 @SergeyKanzhelev

It is possible to get a cgroupv2 cluster but you may have to target it specifically. We have examples of cgroupv2 jobs.

This issue is about the cluster on which we run the prowjob pods, so that nested local clusters (like KIND, hack/local-up-cluster.sh) run on cgroupsv2.

We could create a cgroupsv2 node-pool or cluster on GKE and run some jobs there 1, someone else from k8s infra will have to chime in for the EKS clusters. @xmudrii

Footnotes

  1. https://cloud.google.com/kubernetes-engine/docs/how-to/node-system-config#cgroup-mode-options

@k8s-ci-robot k8s-ci-robot added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Jan 26, 2024
@dims
Copy link
Member

dims commented Apr 10, 2024

fyi all the ci jobs wiht al2023 in their names are cgroupsv2

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2024
@BenTheElder
Copy link
Member

/remove-lifecycle stale

We're still going to want to sort this out at some point, eventually this will be the default even ...

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2024
@dims
Copy link
Member

dims commented Jul 9, 2024

we have a lot of cgroupv2 jobs now ... https://prow.k8s.io/?job=*cgroupv2*

@BenTheElder
Copy link
Member

we have a lot of cgroupv2 jobs now ... https://prow.k8s.io/?job=*cgroupv2*

Yes, and that's probably more than enough for now, but at some point the prow clusters will also wind up migrating, and we could make sure kind etc are tested that way.

For now, I guess the cloudy E2E are enough and we can track this kubernetes/k8s.io#5276 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

7 participants