-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix keyword should not close other PRs, only Issues #5189
Comments
@sjenning This is a github feature, not related to kubernetes bots: https://help.github.com/articles/closing-issues-using-keywords/ If a PR author adds a keyword like that, and the account that does the merge has the ability to close the issue/PR (the bots have access to all k/ repos), then it will look as though the bot closed the issue/PR. |
@cblecker ah ok. My thinking was that close was attributed to the bot, hence the confusion.
|
Maybe we should raise an issue with GitHub about how they display this? The wording is very misleading. GitHub closes the issue in response to the merge but they attribute it to the account that merged 😕 |
This happened here kubernetes/kubernetes#54593
Where the syntax "fix #54593" was used in another PR description and it closed the PR.
IMO, auto-closing should only happen if the target is an Issue.
@joelsmith @dashpole
The text was updated successfully, but these errors were encountered: