fix keyword should not close other PRs, only Issues

[sjenning]

This happened here kubernetes/kubernetes#54593

Where the syntax "fix #54593" was used in another PR description and it closed the PR.

IMO, auto-closing should only happen if the target is an Issue.

@joelsmith @dashpole

[cblecker]

@sjenning This is a github feature, not related to kubernetes bots: https://help.github.com/articles/closing-issues-using-keywords/

If a PR author adds a keyword like that, and the account that does the merge has the ability to close the issue/PR (the bots have access to all k/ repos), then it will look as though the bot closed the issue/PR.

[sjenning]

@cblecker ah ok. My thinking was that close was attributed to the bot, hence the confusion.

k8s-merge-robot closed this in #54597 8 hours ago

[BenTheElder]

Maybe we should raise an issue with GitHub about how they display this? The wording is very misleading. GitHub closes the issue in response to the merge but they attribute it to the account that merged 😕

[spxtr]

I've asked GitHub about this feature since it's pretty confusing. Didn't get much of a response. It's particularly annoying that it closes issues in other repos when you sync your fork.