Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make gce-cos-k8sbeta-default release-blocking #16662

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Make gce-cos-k8sbeta-default release-blocking #16662

merged 1 commit into from
Mar 6, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Mar 6, 2020

gce-cos-master-default is release-blocking, this should be too

trimmed testgridNumFailuresToAlert to match other release-blocking jobs

/sig release
FYI @kubernetes/ci-signal

Followup to #15803

@spiffxp
Make gce-cos-k8sbeta-default release-blocking
bcc8d70 
gce-cos-master-default is release-blocking, this should be too

trimmed testgridNumFailuresToAlert to match other release-blocking jobs
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 6, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Mar 6, 2020

/uncc @idealhack @feiskyer
/cc @alejandrox1 @droslean @justaugustus

@k8s-ci-robot k8s-ci-robot requested review from alejandrox1, droslean and justaugustus and removed request for idealhack and feiskyer March 6, 2020 20:56
@justaugustus
Copy link
Member

Thanks Aaron!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit eaedd22 into kubernetes:master Mar 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 6, 2020
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key generated.yaml using file config/jobs/kubernetes/generated/generated.yaml

In response to this:

gce-cos-master-default is release-blocking, this should be too

trimmed testgridNumFailuresToAlert to match other release-blocking jobs

/sig release
FYI @kubernetes/ci-signal

Followup to #15803

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp spiffxp deleted the gce-cos-1.18-default-blocking branch March 6, 2020 22:36
@spiffxp
Copy link
Member Author

spiffxp commented Mar 11, 2020

ref: #9363

@spiffxp spiffxp mentioned this pull request Mar 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

@droslean droslean Awaiting requested review from droslean

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @justaugustus @k8s-ci-robot