Skip to content

Commit

Permalink
address comments from sttts
Browse files Browse the repository at this point in the history
  • Loading branch information
roycaihw committed Mar 13, 2019
1 parent 4f34cdc commit 95f8951
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ of [OpenAPI v2 spec](docs/concepts/overview/kubernetes-api.md#openapi-and-swagge
Kubernetes API server.

The published schema will be consumed by [kubectl](/docs/reference/kubectl/overview) to perform client-side
validation on custom resources, and can be consumed for other purpose. The feature is disabled by default.
validation on custom resources, and can be consumed for other purpose. The feature is Alpha in 1.14 and disabled by default.
You can enable the feature using the `CustomResourcePublishOpenAPI` feature gate on the
[kube-apiserver](/docs/admin/kube-apiserver):

Expand All @@ -371,7 +371,7 @@ kubectl in previous 1.13 version. These modifications prevent kubectl from being
valid openapi schemas that it doesn't understand. The conversion won't modify the validation schema defined in CRD,
and therefore won't affect [validation](#validation) in API server.

1. The following fields are removed as they aren't supported by OpenAPI v2
1. The following fields are removed as they aren't supported by OpenAPI v2 (in future versions OpenAPI v3 will be used without these restrictions)

- The fields `oneOf`, `anyOf` and `not` are removed

Expand All @@ -394,7 +394,7 @@ and therefore won't affect [validation](#validation) in API server.
- For a schema with no type specified
- the field `properties` is removed

3. The following fields are removed as they aren't supported by gnostic
3. The following fields are removed as they aren't supported by the OpenAPI protobuf implementation

- The fields `id`, `schema`, `definitions`, `additionalItems`, `dependencies`,
and `patternProperties` are removed
Expand Down

0 comments on commit 95f8951

Please sign in to comment.