Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Flannel manifest URL #10569

Closed
1 of 2 tasks
atoato88 opened this issue Oct 10, 2018 · 5 comments
Closed
1 of 2 tasks

Update Flannel manifest URL #10569

atoato88 opened this issue Oct 10, 2018 · 5 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@atoato88
Copy link
Contributor

This is a...

  • Feature Request
  • Bug Report

Problem:
Deployment cluster with Flannel is stuck at "Installing a pod network add-on" section.

As of now, instruction of this page1(at Flannel tab) say following.

kubectl apply -f https://raw.githubusercontent.com/coreos/flannel/v0.10.0/Documentation/kube-flannel.yml

But this manifest is old. Toleration of DaemonSet is insufficient.
As a result of this, kube-flannel Pod doesn't run.

Proposed Solution:
At coreos/flannel2 repository, issue3 exists and PR is merged4.

Should change instructions at kubectl apply -f
from

https://raw.githubusercontent.com/coreos/flannel/v0.10.0/Documentation/kube-flannel.yml

to

https://raw.githubusercontent.com/coreos/flannel/bc79dd1505b0c8681ece4de4c0d86c5cd2643275/Documentation/kube-flannel.yml

Page to Update:
https://kubernetes.io/docs/setup/independent/create-cluster-kubeadm/#pod-network

v1.12.0

@tengqm
Copy link
Contributor

tengqm commented Oct 10, 2018

Should we wait for the next release of flannel?

@neolit123
Copy link
Member

@tengqm @atoato88

Should we wait for the next release of flannel?

the 0.11.0 release of flannel is nowhere in sight.
i agree with this change as it would unbreak flannel for k8s 1.12.

i think the tab should move to a single link instead of having the two links - one for 0.10.0 and one with a SHA having the multi-arch support.

the link:
https://raw.githubusercontent.com/coreos/flannel/bc79dd1505b0c8681ece4de4c0d86c5cd2643275/Documentation/kube-flannel.yml
is correct.

@atoato88 would you be able to send a PR for this?

@neolit123
Copy link
Member

neolit123 commented Oct 10, 2018

/kind bug
/priority critical-urgent
/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Oct 10, 2018
@atoato88
Copy link
Contributor Author

@neolit123 OK, I'll create PR.

@neolit123
Copy link
Member

thank you! please mention me on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Development

No branches or pull requests

5 participants
@neolit123 @atoato88 @tengqm @k8s-ci-robot and others