-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logo Overlaps with Menu in RTL Languages #45077
Comments
This issue is currently awaiting triage. SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area web-development |
@mboukhalfa is it an issue with all RTL languages? |
In that case, we'll need a more flexible solution than just changing the css positions; I've got something in mind |
yes it is |
Can you elaborate what a flexible solution would be ? |
/area localization /remove-kind bug |
See #41171 for an issue about reducing our level of customization. It's useful work that we have not yet staffed. |
Hi all: if you could upvote google/docsy#1442 that would help it get some traction. |
Hmm I think I found the issue it seems we are using website/layouts/partials/navbar.html Line 4 in 95ca859
twbs/bootstrap#22780 (comment) Probably using |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
This is a Bug Report
Problem:
When switching to an RTL language, the logo overlaps with the menu, creating a layout issue as shown in the picture! This is different form the issue google/docsy#1442 and google/docsy#829 these issues are discussing switching the positioning for of menu elements to fit with RTL but the logo overlap problem is not observed in the docsy check: https://example.docsy.dev/fa/
The root cause of the problem is suspected to be the custom CSS applied in the k8s website. Here
website/assets/scss/_custom.scss
Lines 132 to 139 in 95ca859
Proposed Solution:
To fix this we can override the logo position with RTL languages for example:
However, it's recommended to consider a more comprehensive solution. Refactoring the custom CSS added to the k8s website. We have big custom css (>1000 lines ) overriding the default docsy! might be necessary to avoid interfering with the default docsy styling. It's advisable to minimize overrides to essential elements, aligning with the purpose of using docsy. This approach ensures a cleaner separation between documentation content and web development concerns.
Page to Update:
https://deploy-preview-45056--kubernetes-io-main-staging.netlify.app/ar/
The text was updated successfully, but these errors were encountered: