Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation resource.kubernetes.io/pod-claim-name not registered or documented #47044

Open
sftim opened this issue Jun 30, 2024 · 5 comments · May be fixed by #47093
Open

Annotation resource.kubernetes.io/pod-claim-name not registered or documented #47044

sftim opened this issue Jun 30, 2024 · 5 comments · May be fixed by #47093
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented Jun 30, 2024

This is a Bug Report

Problem: The annotation resource.kubernetes.io/pod-claim-name is unregistered, but used in Kubernetes code.

The code comment says:

	// podResourceClaimAnnotation is the special annotation that generated
	// ResourceClaims get. Its value is the pod.spec.resourceClaims[].name
	// for which it was generated. This is used only inside the controller
	// and not documented as part of the Kubernetes API.

However, we don't have a mechanism to register annotations that are not also documented. So, it needs registering.

Proposed Solution:
Register the annotation, by mentioning it in Well-Known Labels, Annotations and Taints.

Page to Update:
https://kubernetes.io/docs/reference/labels-annotations-taints/

Additional Information:
/sig node
Required for kubernetes/enhancements#3063

@sftim sftim added the kind/bug Categorizes issue or PR as related to a bug. label Jun 30, 2024
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 30, 2024
@T-Lakshmi
Copy link
Contributor

/assign

@dipesh-rawat
Copy link
Member

/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 1, 2024
@sftim
Copy link
Contributor Author

sftim commented Jul 1, 2024

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jul 1, 2024
@abhilasha2418
Copy link
Contributor

/assign

@T-Lakshmi
Copy link
Contributor

/unassign

Unassigning my self as PR is already raised by @abhilasha2418.
PR raised for this issue #47093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Triaged
Development

Successfully merging a pull request may close this issue.

5 participants