Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate NonPreemptingPriority to GA #31283

Merged
merged 1 commit into from
Feb 12, 2022
Merged

Graduate NonPreemptingPriority to GA #31283

merged 1 commit into from
Feb 12, 2022

Conversation

denkensk
Copy link
Member

Update the doc
ref kubernetes/enhancements#902

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 11, 2022
This was referenced Jan 11, 2022
Closed
Closed
@netlify
Copy link

netlify bot commented Jan 11, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 665f51e

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61f216cb9469600007d8ac96

😎 Browse the preview: https://deploy-preview-31283--kubernetes-io-main-staging.netlify.app

@denkensk
Copy link
Member Author

/assign @jimangel

@denkensk
Copy link
Member Author

/hold
Waiting for #31267 merged.
/cc @sftim

@k8s-ci-robot k8s-ci-robot requested a review from sftim January 11, 2022 09:08
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2022
@sftim
Copy link
Contributor

sftim commented Jan 11, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 11, 2022
@bradtopol
Copy link
Contributor

Assigning @sftim since he is the one engaged on this.
/assign @sftim

@denkensk denkensk force-pushed the graduate-nonpreemptingpriority-to-ga branch from 574b444 to 665f51e Compare January 27, 2022 03:51
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2022
@jimangel
Copy link
Member

jimangel commented Feb 1, 2022 •
edited
Loading

Since we're waiting on kubernetes/kubernetes#107432 to merge, should this PR target dev-1.24?

/cc @nate-double-u
/milestone 1.24

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Feb 1, 2022
@denkensk
Copy link
Member Author

denkensk commented Feb 1, 2022

Since we're waiting on kubernetes/kubernetes#107432 to merge, should this PR target dev-1.24?

/cc @nate-double-u

/milestone 1.24

yes, this is for 1.24

@nate-double-u
Copy link
Contributor

I agree with @jimangel, if this is for 1.24, it should target the dev-1.24. Thanks @denkensk!

@denkensk
Copy link
Member Author

denkensk commented Feb 1, 2022

@nate-double-u
I will change the target branch to dev-1.24.
I want to know if I need to sync to main or not？or some automatic will do it？

@nate-double-u
Copy link
Contributor

Depending on which branch you split from, there will be some commits that may be removed from the timeline, but that's intentional.

Here's GitHubs docs on swapping base branches. Let us know if this doesn't answer your concerns @denkensk 🙂

@denkensk denkensk changed the base branch from main to dev-1.24 February 2, 2022 14:29
@denkensk
Copy link
Member Author

denkensk commented Feb 8, 2022

Assigning @sftim since he is the one engaged on this.

/assign @sftim

since kubernetes/kubernetes#107432 has been merged
@sftim pls review this pr.

@denkensk
Copy link
Member Author

denkensk commented Feb 8, 2022

I agree with @jimangel, if this is for 1.24, it should target the dev-1.24. Thanks @denkensk!

Done

@nate-double-u
Copy link
Contributor

nate-double-u commented Feb 9, 2022 •
edited
Loading

/cc @PI-Victor (this relates to one of the KEPs you're tracking for 1.24)

@PI-Victor
Copy link
Member

NFC
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0d62fd24a73ef901d6c6893092e1312f700a7fdb

@denkensk
Copy link
Member Author

/assign @celestehorgan
Could you approve it?

@reylejano
Copy link
Member

The changes look good for 1.24
Thank you
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit c3c3b1a into kubernetes:dev-1.24 Feb 12, 2022
@denkensk denkensk deleted the graduate-nonpreemptingpriority-to-ga branch February 12, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidopp davidopp Awaiting requested review from davidopp

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@sftim sftim Awaiting requested review from sftim

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@jimangel jimangel

@PI-Victor PI-Victor

@celestehorgan celestehorgan

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.
9 participants
@denkensk @sftim @bradtopol @jimangel @nate-double-u @PI-Victor @k8s-ci-robot @reylejano @celestehorgan