From ff94a5c1bcf90338e11d6ff2e78aebd5427de7df Mon Sep 17 00:00:00 2001 From: Brad Topol Date: Wed, 11 Oct 2017 12:33:20 -0700 Subject: [PATCH 1/4] Fixes issue #5620 Signed-off-by: Brad Topol --- README.md | 2 ++ docs/home/contribute/create-pull-request.md | 2 ++ 2 files changed, 4 insertions(+) diff --git a/README.md b/README.md index 280a4ceb400a6..2046c5d25ecf8 100644 --- a/README.md +++ b/README.md @@ -4,6 +4,8 @@ Welcome! We are very pleased you want to contribute to the Kubernetes documentat You can click the **Fork** button in the upper-right area of the screen to create a copy of this repository in your GitHub account called a *fork*. Make any changes you want in your fork, and when you are ready to send those changes to us, go to your fork and create a new pull request to let us know about it. +Once your pull request is created, a [Kubernetes reviewer](https://github.com/kubernetes/kubernetes.github.io/blob/master/OWNERS) will take responsibility for providing clear, actionable feedback. As the owner of the pull request, **it is your responsibility to modify your pull request to address the feedback that has been provided to you by the Kubernetes reviewer.** Also note that you may end up having more than one Kubernetes reviewer provide you feedback or you may end up getting feedback from a Kubernetes reviewer that is different than the one originally assigned to provide you feedback. Reviewers will do their best to provide feedback in a timely fashion but response time can vary based on circumstances. + For more information about contributing to the Kubernetes documentation, see: * [Contributing to the Kubernetes Documentation](http://kubernetes.io/editdocs/) diff --git a/docs/home/contribute/create-pull-request.md b/docs/home/contribute/create-pull-request.md index 733e18fe75c7c..fef127945b2af 100644 --- a/docs/home/contribute/create-pull-request.md +++ b/docs/home/contribute/create-pull-request.md @@ -81,6 +81,8 @@ site where you can verify that your changes have rendered correctly. If needed, revise your pull request by committing changes to your new branch in your fork. +Once your pull request is created, a [Kubernetes reviewer](https://github.com/kubernetes/kubernetes.github.io/blob/master/OWNERS) will take responsibility for providing clear, actionable feedback. As the owner of the pull request, **it is your responsibility to modify your pull request to address the feedback that has been provided to you by the Kubernetes reviewer.** Also note that you may end up having more than one Kubernetes reviewer provide you feedback or you may end up getting feedback from a Kubernetes reviewer that is different than the one originally assigned to provide you feedback. Reviewers will do their best to provide feedback in a timely fashion but response time can vary based on circumstances. + The staging site for the upcoming Kubernetes release is here: [http://kubernetes-io-vnext-staging.netlify.com/](http://kubernetes-io-vnext-staging.netlify.com/). The staging site reflects the current state of what's been merged in the From ca55fadda474f153511b96c610222f3e75520b91 Mon Sep 17 00:00:00 2001 From: Brad Topol Date: Tue, 17 Oct 2017 07:15:05 -0700 Subject: [PATCH 2/4] Restructured so that review process is for both current and upcoming releases. Added content describing the use of tech reviewers. --- README.md | 2 +- docs/home/contribute/create-pull-request.md | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 2046c5d25ecf8..12cfc8df1cd13 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ Welcome! We are very pleased you want to contribute to the Kubernetes documentat You can click the **Fork** button in the upper-right area of the screen to create a copy of this repository in your GitHub account called a *fork*. Make any changes you want in your fork, and when you are ready to send those changes to us, go to your fork and create a new pull request to let us know about it. -Once your pull request is created, a [Kubernetes reviewer](https://github.com/kubernetes/kubernetes.github.io/blob/master/OWNERS) will take responsibility for providing clear, actionable feedback. As the owner of the pull request, **it is your responsibility to modify your pull request to address the feedback that has been provided to you by the Kubernetes reviewer.** Also note that you may end up having more than one Kubernetes reviewer provide you feedback or you may end up getting feedback from a Kubernetes reviewer that is different than the one originally assigned to provide you feedback. Reviewers will do their best to provide feedback in a timely fashion but response time can vary based on circumstances. +Once your pull request is created, a [Kubernetes reviewer](https://github.com/kubernetes/kubernetes.github.io/blob/master/OWNERS) will take responsibility for providing clear, actionable feedback. As the owner of the pull request, **it is your responsibility to modify your pull request to address the feedback that has been provided to you by the Kubernetes reviewer.** Also note that you may end up having more than one Kubernetes reviewer provide you feedback or you may end up getting feedback from a Kubernetes reviewer that is different than the one originally assigned to provide you feedback. Furthermore, in some cases, one of your reviewers might ask for a technical review from a [Kubernetes tech reviewer](https://github.com/kubernetes/kubernetes.github.io/wiki/Tech-reviewers) when needed. Reviewers will do their best to provide feedback in a timely fashion but response time can vary based on circumstances. For more information about contributing to the Kubernetes documentation, see: diff --git a/docs/home/contribute/create-pull-request.md b/docs/home/contribute/create-pull-request.md index fef127945b2af..1281388021fda 100644 --- a/docs/home/contribute/create-pull-request.md +++ b/docs/home/contribute/create-pull-request.md @@ -81,14 +81,15 @@ site where you can verify that your changes have rendered correctly. If needed, revise your pull request by committing changes to your new branch in your fork. -Once your pull request is created, a [Kubernetes reviewer](https://github.com/kubernetes/kubernetes.github.io/blob/master/OWNERS) will take responsibility for providing clear, actionable feedback. As the owner of the pull request, **it is your responsibility to modify your pull request to address the feedback that has been provided to you by the Kubernetes reviewer.** Also note that you may end up having more than one Kubernetes reviewer provide you feedback or you may end up getting feedback from a Kubernetes reviewer that is different than the one originally assigned to provide you feedback. Reviewers will do their best to provide feedback in a timely fashion but response time can vary based on circumstances. - The staging site for the upcoming Kubernetes release is here: [http://kubernetes-io-vnext-staging.netlify.com/](http://kubernetes-io-vnext-staging.netlify.com/). The staging site reflects the current state of what's been merged in the release branch, or in other words, what the docs will look like for the next upcoming release. It's automatically updated as new PRs get merged. +## Pull request review process for both Current and Upcoming Releases +Once your pull request is created, a [Kubernetes reviewer](https://github.com/kubernetes/kubernetes.github.io/blob/master/OWNERS) will take responsibility for providing clear, actionable feedback. As the owner of the pull request, **it is your responsibility to modify your pull request to address the feedback that has been provided to you by the Kubernetes reviewer.** Also note that you may end up having more than one Kubernetes reviewer provide you feedback or you may end up getting feedback from a Kubernetes reviewer that is different than the one originally assigned to provide you feedback. Furthermore, in some cases, one of your reviewers might ask for a technical review from a [Kubernetes tech reviewer](https://github.com/kubernetes/kubernetes.github.io/wiki/Tech-reviewers) when needed. Reviewers will do their best to provide feedback in a timely fashion but response time can vary based on circumstances. + {% endcapture %} {% capture whatsnext %} From e6ceda55e1771eb74b4c157bdac068bf3c78d61f Mon Sep 17 00:00:00 2001 From: Brad Topol Date: Tue, 17 Oct 2017 10:26:45 -0700 Subject: [PATCH 3/4] Removed incorrect Kubernetes reviewer link. --- README.md | 2 +- docs/home/contribute/create-pull-request.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 12cfc8df1cd13..37dcfa59b7b0a 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ Welcome! We are very pleased you want to contribute to the Kubernetes documentat You can click the **Fork** button in the upper-right area of the screen to create a copy of this repository in your GitHub account called a *fork*. Make any changes you want in your fork, and when you are ready to send those changes to us, go to your fork and create a new pull request to let us know about it. -Once your pull request is created, a [Kubernetes reviewer](https://github.com/kubernetes/kubernetes.github.io/blob/master/OWNERS) will take responsibility for providing clear, actionable feedback. As the owner of the pull request, **it is your responsibility to modify your pull request to address the feedback that has been provided to you by the Kubernetes reviewer.** Also note that you may end up having more than one Kubernetes reviewer provide you feedback or you may end up getting feedback from a Kubernetes reviewer that is different than the one originally assigned to provide you feedback. Furthermore, in some cases, one of your reviewers might ask for a technical review from a [Kubernetes tech reviewer](https://github.com/kubernetes/kubernetes.github.io/wiki/Tech-reviewers) when needed. Reviewers will do their best to provide feedback in a timely fashion but response time can vary based on circumstances. +Once your pull request is created, a Kubernetes reviewer will take responsibility for providing clear, actionable feedback. As the owner of the pull request, **it is your responsibility to modify your pull request to address the feedback that has been provided to you by the Kubernetes reviewer.** Also note that you may end up having more than one Kubernetes reviewer provide you feedback or you may end up getting feedback from a Kubernetes reviewer that is different than the one originally assigned to provide you feedback. Furthermore, in some cases, one of your reviewers might ask for a technical review from a [Kubernetes tech reviewer](https://github.com/kubernetes/kubernetes.github.io/wiki/Tech-reviewers) when needed. Reviewers will do their best to provide feedback in a timely fashion but response time can vary based on circumstances. For more information about contributing to the Kubernetes documentation, see: diff --git a/docs/home/contribute/create-pull-request.md b/docs/home/contribute/create-pull-request.md index 1281388021fda..2a1ce72c50890 100644 --- a/docs/home/contribute/create-pull-request.md +++ b/docs/home/contribute/create-pull-request.md @@ -88,7 +88,7 @@ release branch, or in other words, what the docs will look like for the next upcoming release. It's automatically updated as new PRs get merged. ## Pull request review process for both Current and Upcoming Releases -Once your pull request is created, a [Kubernetes reviewer](https://github.com/kubernetes/kubernetes.github.io/blob/master/OWNERS) will take responsibility for providing clear, actionable feedback. As the owner of the pull request, **it is your responsibility to modify your pull request to address the feedback that has been provided to you by the Kubernetes reviewer.** Also note that you may end up having more than one Kubernetes reviewer provide you feedback or you may end up getting feedback from a Kubernetes reviewer that is different than the one originally assigned to provide you feedback. Furthermore, in some cases, one of your reviewers might ask for a technical review from a [Kubernetes tech reviewer](https://github.com/kubernetes/kubernetes.github.io/wiki/Tech-reviewers) when needed. Reviewers will do their best to provide feedback in a timely fashion but response time can vary based on circumstances. +Once your pull request is created, a Kubernetes reviewer will take responsibility for providing clear, actionable feedback. As the owner of the pull request, **it is your responsibility to modify your pull request to address the feedback that has been provided to you by the Kubernetes reviewer.** Also note that you may end up having more than one Kubernetes reviewer provide you feedback or you may end up getting feedback from a Kubernetes reviewer that is different than the one originally assigned to provide you feedback. Furthermore, in some cases, one of your reviewers might ask for a technical review from a [Kubernetes tech reviewer](https://github.com/kubernetes/kubernetes.github.io/wiki/Tech-reviewers) when needed. Reviewers will do their best to provide feedback in a timely fashion but response time can vary based on circumstances. {% endcapture %} From 7ee242203420d5f40d25d9ee726ede8978ba6f7d Mon Sep 17 00:00:00 2001 From: Brad Topol Date: Thu, 19 Oct 2017 12:59:39 -0700 Subject: [PATCH 4/4] Fixed tech reviewer URL to now use website --- README.md | 2 +- docs/home/contribute/create-pull-request.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 37dcfa59b7b0a..9eb11944ded97 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ Welcome! We are very pleased you want to contribute to the Kubernetes documentat You can click the **Fork** button in the upper-right area of the screen to create a copy of this repository in your GitHub account called a *fork*. Make any changes you want in your fork, and when you are ready to send those changes to us, go to your fork and create a new pull request to let us know about it. -Once your pull request is created, a Kubernetes reviewer will take responsibility for providing clear, actionable feedback. As the owner of the pull request, **it is your responsibility to modify your pull request to address the feedback that has been provided to you by the Kubernetes reviewer.** Also note that you may end up having more than one Kubernetes reviewer provide you feedback or you may end up getting feedback from a Kubernetes reviewer that is different than the one originally assigned to provide you feedback. Furthermore, in some cases, one of your reviewers might ask for a technical review from a [Kubernetes tech reviewer](https://github.com/kubernetes/kubernetes.github.io/wiki/Tech-reviewers) when needed. Reviewers will do their best to provide feedback in a timely fashion but response time can vary based on circumstances. +Once your pull request is created, a Kubernetes reviewer will take responsibility for providing clear, actionable feedback. As the owner of the pull request, **it is your responsibility to modify your pull request to address the feedback that has been provided to you by the Kubernetes reviewer.** Also note that you may end up having more than one Kubernetes reviewer provide you feedback or you may end up getting feedback from a Kubernetes reviewer that is different than the one originally assigned to provide you feedback. Furthermore, in some cases, one of your reviewers might ask for a technical review from a [Kubernetes tech reviewer](https://github.com/kubernetes/website/wiki/Tech-reviewers) when needed. Reviewers will do their best to provide feedback in a timely fashion but response time can vary based on circumstances. For more information about contributing to the Kubernetes documentation, see: diff --git a/docs/home/contribute/create-pull-request.md b/docs/home/contribute/create-pull-request.md index 2a1ce72c50890..f06d64a30eb25 100644 --- a/docs/home/contribute/create-pull-request.md +++ b/docs/home/contribute/create-pull-request.md @@ -88,7 +88,7 @@ release branch, or in other words, what the docs will look like for the next upcoming release. It's automatically updated as new PRs get merged. ## Pull request review process for both Current and Upcoming Releases -Once your pull request is created, a Kubernetes reviewer will take responsibility for providing clear, actionable feedback. As the owner of the pull request, **it is your responsibility to modify your pull request to address the feedback that has been provided to you by the Kubernetes reviewer.** Also note that you may end up having more than one Kubernetes reviewer provide you feedback or you may end up getting feedback from a Kubernetes reviewer that is different than the one originally assigned to provide you feedback. Furthermore, in some cases, one of your reviewers might ask for a technical review from a [Kubernetes tech reviewer](https://github.com/kubernetes/kubernetes.github.io/wiki/Tech-reviewers) when needed. Reviewers will do their best to provide feedback in a timely fashion but response time can vary based on circumstances. +Once your pull request is created, a Kubernetes reviewer will take responsibility for providing clear, actionable feedback. As the owner of the pull request, **it is your responsibility to modify your pull request to address the feedback that has been provided to you by the Kubernetes reviewer.** Also note that you may end up having more than one Kubernetes reviewer provide you feedback or you may end up getting feedback from a Kubernetes reviewer that is different than the one originally assigned to provide you feedback. Furthermore, in some cases, one of your reviewers might ask for a technical review from a [Kubernetes tech reviewer](https://github.com/kubernetes/website/wiki/Tech-reviewers) when needed. Reviewers will do their best to provide feedback in a timely fashion but response time can vary based on circumstances. {% endcapture %}