Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @bradtopol from SIG Docs reviewer to approver #7729

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Move @bradtopol from SIG Docs reviewer to approver #7729

merged 1 commit into from
Mar 13, 2018

Conversation

zacharysarah
Copy link
Contributor

This PR moves @bradtopol from reviewer to approver for SIG Docs.

I will also add him to @kubernetes/sig-docs-maintainers.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b86e182

https://deploy-preview-7729--kubernetes-io-master-staging.netlify.com

@heckj
Copy link
Contributor

heckj commented Mar 13, 2018

👍 from the SIG Docs meeting today

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heckj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2018
@heckj
Copy link
Contributor

heckj commented Mar 13, 2018

@bradtopol FYI

@k8s-ci-robot k8s-ci-robot merged commit b34babb into kubernetes:master Mar 13, 2018
@zacharysarah zacharysarah deleted the brad-topol-for-maintainer branch March 13, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants