Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image tag in Helm chart should be configurable #88

Closed
bhavin192 opened this issue May 9, 2019 · 1 comment
Closed

Image tag in Helm chart should be configurable #88

bhavin192 opened this issue May 9, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@bhavin192
Copy link
Contributor

Is your feature request related to a problem? Please describe.
If we build BotKube image for some bug fix or want to use image with a tag like latest then one should be able to set that image tag while installing BotKube with Helm chart.

Describe the solution you'd like
Changing the version from Chart.yaml is not a clean solution, also it won't allow to set it to tag values which are not according to sem ver 2. We should have .Values.image.tag

https://helm.sh/docs/developing_charts/#charts-and-versioning
@bhavin192 bhavin192 added the enhancement New feature or request label May 9, 2019
@bhavin192 bhavin192 mentioned this issue May 9, 2019
Merged
@bhavin192
Copy link
Contributor Author

Fixed by #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bhavin192