Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run containers using Non Privileged user #168

Merged
merged 1 commit into from
Sep 1, 2019
Merged

Run containers using Non Privileged user #168

merged 1 commit into from
Sep 1, 2019

Conversation

codenio
Copy link
Contributor

@codenio codenio commented Aug 30, 2019

ISSUE TYPE
  • Feature Pull Request
SUMMARY

This PR,

  • runs botkube containers as Non Privileged user
  • adds securityContext filed to containers in all yaml files.
  • adds securityContext fields to helm charts

Fixes #161

@codenio
Run containers using Non Privileged user
8727d97 
This Commit,
- runs botkube containers as Non Privileged user
- adds `securityContext` filed to containers in all yaml files.
- adds `securityContext` fields to helm charts
@PrasadG193 PrasadG193 merged commit 600ad6d into kubeshop:develop Sep 1, 2019
@PrasadG193
Copy link
Collaborator

Merged! Thanks for the PR @aananthraj

@codenio codenio deleted the feature/run-as-non-root branch September 1, 2019 05:40
@codenio
Copy link
Contributor Author

codenio commented Sep 1, 2019

Thanks @PrasadG193 for merging this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@bhavin192 bhavin192 Awaiting requested review from bhavin192

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run as non-root
2 participants
@codenio @PrasadG193