Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for kubectl command on forbidden verbs and resources #374

Merged
merged 5 commits into from
Oct 1, 2020
Merged

Add tests for kubectl command on forbidden verbs and resources #374

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3890ce5
Add tests for kubectl command on forbidden verbs and resources
anoopmsivadas Oct 1, 2020
9549d92
Merge branch 'develop' into issue-350
mergify[bot] Oct 1, 2020
69ebb1a
Add tests for kubectl command on forbidden verbs and resources
anoopmsivadas Oct 1, 2020
ce3fa4e
Merge remote-tracking branch 'upstream/develop' into issue-350
anoopmsivadas Oct 1, 2020
a97c4bd
Merge branch 'issue-350' of https://github.com/anoopmsivadas/botkube …
anoopmsivadas Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/e2e/command/kubectl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,16 @@ func (c *context) testKubectlCommand(t *testing.T) {
expected: fmt.Sprintf("<@U023BECGF> get pods"),
channel: "dummy",
},
"kubectl command on forbidden verb and resource": {
command: "config set clusters.test-clustor-1.server https://1.2.3.4",
expected: "```Command not supported. Please run /botkubehelp to see supported commands.```",
channel: c.Config.Communications.Slack.Channel,
},
"kubectl command on forbidden resource": {
command: "get endpoints",
expected: "```Command not supported. Please run /botkubehelp to see supported commands.```",
channel: c.Config.Communications.Slack.Channel,
},
}

for name, test := range tests {
Expand Down