Feature Request: Support retained PV as source

[haslersn]

Is your feature request related to a problem? Please describe:

I accidentally deleted a DataVolume. The PersistentVolume was still there. I wanted to reuse it, including its content. However, containerized-data-importer currently doesn't support this.

Describe the solution you'd like:

Perhaps something like the following could be made to work. To date, this doesn't work, because the importer would create a blank disk inside the volume, AFAIK.

  source:
    blank: {}
  pvc:
    accessModes:
      - ReadWriteOnce
    resources:
      requests:
        storage: 1Gi
    volumeName: <PV to reclaim>

Describe alternatives you've considered:

I think a workaround is to manually create a PVC to reclaim the PV and then use the PVC source. However, this would create a copy of the data.

[mhenriks]

hi @haslersn, as a workaround, you should be able to create a pvc that is explicitly bound to the retained PV. Add the following annotation to the PVC:

cdi.kubevirt.io/storage.populatedFor: <pvc name>

Then when the DataVolume with same name as the PVC is created, the DataVolume controller should skip population and mark the DataVolume succeeded.

[kubevirt-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[haslersn]

/remove-lifecycle stale

[kubevirt-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[haslersn]

/remove-lifecycle stale

[aglitke]

@mhenriks may have some updated information for you on this issue...

[kubevirt-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[haslersn]

/remove-lifecycle stale

@mhenriks is there an update (as suggested by @aglitke)?

[akalenyu]

One possible workaround which was introduced for this in #2683
is to specify a dummy unique storage class name on both the DV & PV
(just for sake of binding).

Regarding the full functionality which was suggested (volumeName), I believe we do not have a solution for that yet.

[alromeros]

Hey @haslersn, I think this feature is one that might come in handy in your case: #2583.

Basically, now you can create a DV with the cdi.kubevirt.io/storage.checkStaticVolume annotation, so CDI will look for PVs with claimrefs that match its name and namespace. There's more information in the PR, but creating a DV with the same name and namespace as before and that annotation should be enough.

Let us know if this fixes your problem!

[alromeros]

Hey @haslersn, closing the issue since the topic has been addressed (should be fixed by the previous approach). Feel free to reopen if you want to follow up on the discussion or have other related issues. Thanks!