Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updatecli automation bumps patch release images without image present #500

Open
viccuad opened this issue Jul 31, 2024 · 0 comments
Open
Labels
area/ci kind/bug Something isn't working

Comments

@viccuad
Copy link
Member

viccuad commented Jul 31, 2024

It seems that the updatecli automation for patch releases bumps images even if they don't exist.

For example, here it bumped the audit-scanner image to v1.15.1 even if no such tag or release exists.
(yet there is the usual draft release).

This may be because updatecli.d/patch-kubewarden-kubewraden-*.yaml lack some conditions to check for the image version, e.g:

conditions:
# All the major components must have the same tag
kwctlTag:
name: Test if kwctl has the required tag
disablesourceinput: true
kind: gittag
scmid: kwctlGit
spec:
versionfilter:
kind: "semver"
pattern: "{{ requiredEnv .releaseVersion }}"
kubewardenControllerTag:
name: Test if kubewarden-controller has the required tag
disablesourceinput: true
kind: gittag
scmid: kubewardenControllerGit
spec:
versionfilter:
kind: "semver"
pattern: "{{ requiredEnv .releaseVersion }}"
policyServerTag:
name: Test if Policy Server has the required tag
disablesourceinput: true
kind: gittag
scmid: policyServerGit
spec:
versionfilter:
kind: "semver"
pattern: "{{ requiredEnv .releaseVersion }}"
auditScannerTag:
name: Test if audit-scanner has the required tag
disablesourceinput: true
kind: gittag
scmid: auditScannerGit
spec:
versionfilter:
kind: "semver"
pattern: "{{ requiredEnv .releaseVersion }}"

See:
https://github.com/kubewarden/helm-charts/actions/runs/10181224959/job/28160875951#step:9:83
Noticed here:
#499 (comment)

Acceptance criteria

  • Automations on updatecli.d/patch-kubewarden-kubewraden-*.yaml checks that all images exist prior to bumping them.
@viccuad viccuad added kind/bug Something isn't working area/ci labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant