Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow testing Telemetry configuration in integration tests #937

Open
jvanz opened this issue Dec 12, 2024 · 1 comment
Open

Allow testing Telemetry configuration in integration tests #937

jvanz opened this issue Dec 12, 2024 · 1 comment

Comments

@jvanz
Copy link
Member

jvanz commented Dec 12, 2024

While working on PR #934, Codecov reported a lack of tests for the changes made to the PolicyServerReconciler and related changes, which added the required configuration in the policy server deployment. As a result, code coverage in the codebase has dropped.

The telemetry configuration is stored in the reconciler struct, which poses a challenge for writing proper tests for these changes. This issue cannot be easily addressed due to the fact that reconciler instances are created during test initialization, and it is not possible to have multiple test suites. Therefore, we need to find another way to enable configuration or recreation of the reconciler before certain tests.

Acceptance Criteria

  • Write integration tests to cover all telemetry configuration possibilities.
@fabriziosestito
Copy link
Contributor

fabriziosestito commented Dec 12, 2024

We should reconsider initializing reconcilers in the test suite setup function. We could move the reconciler's setup to the tests directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants