Use submodules #57
Open
Use submodules #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e551a7e.
kubilus1
reviewed
Mar 14, 2021
There was a problem hiding this comment.
Thanks for the contribution!
This will need to specify specific sgdk project tags, also need to figure out why the docker image build is not working (I think the gitmodules file is not copied into the image via Dockerfile, but see my other suggestion that might make that redundant, anyhow.)
| SGDK: $(SGDKDIR) | ||
| $(SGDKDIR): | ||
| git clone -b '$(SGDKVER)' --single-branch --depth 1 https://github.com/Stephane-D/SGDK.git | ||
| git submodule update --init |
There was a problem hiding this comment.
We'll want this to represent the SGDK version we want on line 7. (We may not always want the very latest, and also that SGDKVER is used to patch our local SGDK dir for specific tweaks need to run on *nix)
Maybe git submodule add -b tags/$(SGDKVER) ...... before the module update is what we need. (instead of the .gitmodules file)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Forcing updates can be done with
git submodule update. I set the reference to v.1.50.This could be done as part of the pipeline checking the compatibility with SGDK changes every time a change to SGDK is done.
Thanks for your great work. This enables me to do some Mega Drive development on my Mac!