Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeing flakes due to already existing resources #639

Closed
jbarrick-mesosphere opened this issue Jul 24, 2019 · 1 comment · Fixed by #707
Closed

Seeing flakes due to already existing resources #639

jbarrick-mesosphere opened this issue Jul 24, 2019 · 1 comment · Fixed by #707

Comments

@jbarrick-mesosphere
Copy link
Member

What happened:

We're seeing some flakes due to resources already existing, e.g.:

--- FAIL: TestWaitForCRDs (0.12s)
    kubernetes_integration_test.go:98: 
        	Error Trace:	kubernetes_integration_test.go:98
        	Error:      	Expected nil, but got: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:""}, Status:"Failure", Message:"instances.kudo.k8s.io \"zk\" already exists", Reason:"AlreadyExists", Details:(*v1.StatusDetails)(0xc000442060), Code:409}}
        	Test:       	TestWaitForCRDs

I believe this is an issue with the RetryClient that we need to resolve. Likely the first request hit an error and retried, but was still successfully processed by the API server so the resource already existed. We likely can fix these tests by using CreateOrUpdate instead of just Create.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants