fix: set allowSyntheticDefaultImports properly

Fixes #4156
kulshekhar · Jul 10, 2024 · ff4b302 · ff4b302
1 parent 083cd89
commit ff4b302
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 10 deletions.
diff --git a/src/legacy/compiler/__snapshots__/ts-compiler.spec.ts.snap b/src/legacy/compiler/__snapshots__/ts-compiler.spec.ts.snap
@@ -18,7 +18,7 @@ exports[`TsCompiler getCompiledOutput isolatedModules false should compile codes
 
 exports[`TsCompiler getCompiledOutput isolatedModules false should compile codes with useESM {"babelConfig": false, "supportsStaticESM": true, "useESM": true} 1`] = `
 {
-  "allowSyntheticDefaultImports": true,
+  "allowSyntheticDefaultImports": undefined,
   "esModuleInterop": true,
   "module": 1,
 }
@@ -50,7 +50,7 @@ exports[`TsCompiler getCompiledOutput isolatedModules true should transpile code
 
 exports[`TsCompiler getCompiledOutput isolatedModules true should transpile code with config {"babelConfig": false, "supportsStaticESM": true, "useESM": true} 1`] = `
 {
-  "allowSyntheticDefaultImports": true,
+  "allowSyntheticDefaultImports": undefined,
   "esModuleInterop": true,
   "module": 1,
 }

diff --git a/src/legacy/compiler/ts-compiler.ts b/src/legacy/compiler/ts-compiler.ts
@@ -172,7 +172,6 @@ export class TsCompiler implements TsCompilerInstance {
       ...compilerOptions,
       module: moduleKind,
       esModuleInterop: esModuleInterop ?? false,
-      allowSyntheticDefaultImports: esModuleInterop ?? compilerOptions.allowSyntheticDefaultImports,
     }
   }
 

diff --git a/src/legacy/config/config-set.spec.ts b/src/legacy/config/config-set.spec.ts
@@ -97,7 +97,6 @@ describe('parsedTsConfig', () => {
 
     expect(cs.parsedTsConfig.options).toMatchObject({
       module: ts.ModuleKind.AMD,
-      allowSyntheticDefaultImports: true,
       esModuleInterop: false,
     })
     expect(target.lines.warn.join()).toEqual(expect.stringContaining(Errors.ConfigNoModuleInterop))
@@ -839,7 +838,6 @@ describe('_resolveTsConfig', () => {
         expect(readConfig.mock.calls[0][0]).toBe(tscfgPathStub)
         expect(parseConfig.mock.calls[0][2]).toBe('/root')
         expect(parseConfig.mock.calls[0][4]).toBe(tscfgPathStub)
-        expect(conf.options.allowSyntheticDefaultImports).toEqual(true)
         expect(conf.errors).toMatchSnapshot()
       })
 

diff --git a/src/legacy/config/config-set.ts b/src/legacy/config/config-set.ts
@@ -487,11 +487,6 @@ export class ConfigSet {
         start: undefined,
         length: undefined,
       })
-      // at least enable synthetic default imports (except if it's set in the input config)
-      /* istanbul ignore next (already covered in unit test) */
-      if (!('allowSyntheticDefaultImports' in finalOptions)) {
-        finalOptions.allowSyntheticDefaultImports = true
-      }
     }
     // Make sure when allowJs is enabled, outDir is required to have when using allowJs: true
     if (finalOptions.allowJs && !finalOptions.outDir) {